This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Change warning on Server mask length to trigger at < 24 and reword message#6007
Merged
rawlinp merged 1 commit intoapache:masterfrom Jul 9, 2021
Merged
Change warning on Server mask length to trigger at < 24 and reword message#6007rawlinp merged 1 commit intoapache:masterfrom
rawlinp merged 1 commit intoapache:masterfrom
Conversation
ocket8888
added
Traffic Portal v1
rawlinp
approved these changes
Jul 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
This PR changes the warning that appears on large CIDR blocks in Traffic Portal server forms from triggering on < 27 to < 24 and rewords the warning message itself to avoid calling things "problematic".
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure TP tests pass, run TP and try to enter an IPv4 address for a server with a netmask < 27 but not < 24 and observe no warning message, then make it less than 24 and observe that there is a new warning message that doesn't use the word "problematic".
The following criteria are ALL met by this PR