Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

TP Migrate Jobs test from E2E to integrate test#6012

Merged
ocket8888 merged 6 commits intoapache:masterfrom
dpham692:MigrateJobsTest
Jul 16, 2021
Merged

TP Migrate Jobs test from E2E to integrate test#6012
ocket8888 merged 6 commits intoapache:masterfrom
dpham692:MigrateJobsTest

Conversation

@dpham692
Copy link
Contributor

What does this PR (Pull Request) do?

  • This PR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • CDN in a Box
  • Traffic Portal
  • CI tests

What is the best way to verify this PR?

Make sure all tests are migrate in integration/Data/jobs.ts directory.
https://github.com/apache/trafficcontrol/blob/master/traffic_portal/test/e2e_deprecated/jobs/jobs-spec.js
Go to traffic_portal/test/integration and run
npm test -- --params.baseUrl https://localhost --capabilities.shardTestFiles true and make sure test all pass.
Make sure CI tests pass also.

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@rimashah25
Copy link
Contributor

Tests pass on local.
Code LGTM after proposed changes.

@ocket8888 ocket8888 merged commit b735288 into apache:master Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants