Remove duplicate download go func

[bueale]

What does this PR (Pull Request) do?

• This PR fixes ATC GitHub Actions duplicate Go-downloading code #5995

Which Traffic Control components are affected by this PR?

• CI tests

What is the best way to verify this PR?

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

• This PR does not require tests
• This PR does not require necessary documentation updates
• This PR includes No necessary changes to CHANGELOG.md
• This PR includes any and all required license headers
• This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

[zrhoffman]

After removing the GOROOT lines in a2e301d, go-test action from the Go Unit Tests workflow run does not have Go, because it runs in a Docker container. download_go should be re-added to go-test. As for the others, they run directly on the GitHub runner, which already has Go from the GitHub Actions Ubuntu2004 virtual environment.

Not sure why the Traffic Ops Go client/API integration tests / API_tests and TP Integration Tests / TP_Integration_tests workflows are failing.

[zrhoffman]

The Traffic Ops Go client/API integration tests / API_tests and TP Integration Tests / TP_Integration_tests workflows fail because they both use the todb-init action, which uses Go to install Goose to set up the database, and which runs in a Docker container. So download_go needs to be re-added to the todb-init action, too.

[zrhoffman]

Looks good so far. Next, for each workflow that uses a GitHub Action that you removed download_go from, get the Go version from the GO_VERSION file and install that Go version using the actions/setup-go action:

Go version should be be set in the workflow files by

1. Checking the version in the GO_VERSION file:
   

   trafficcontrol/.github/workflows/go.vet.yml

   Lines 43 to 44 in f691cd9

   	- name: go-version
   	run: echo "::set-output name=value::$(cat GO_VERSION)"

   
   Note that id also needs to be set for this step (see #5991).
2. Using the actions/setup-go action with that version.
   

   trafficcontrol/.github/workflows/go.vet.yml

   Lines 45 to 47 in f691cd9

   	- uses: actions/setup-go@v2
   	with:
   	go-version: ${{ steps.go-version.outputs.value }} # The Go version to download (if necessary) and use.

[y377]

Installing

Two machines - physical or virtual -, each with at least two (v)CPUs, 4GB of RAM, and 20 GB of disk space

hi,guys!
Can a cloud server with 1cpu and 2GB ram be installed?

[ocket8888]

missing terminating newline in text file

[zrhoffman]

The dashboard URLs still need to be reverted.
#6026 (comment)
#6026 (comment)

[zrhoffman]

These references to GOROOT should be removed:

https://github.com/apache/trafficcontrol/blob/3b2fc5567ea6a2c3778cf0c7b4801a53d4789b56/.github/actions/check-go-modules/entrypoint.sh#L71-L72

[zrhoffman]

Looks good!

• download_go functions and its remnants are removed from the non-Docker GHAs
• Our GitHub Actions use actions/setup-go to download the Go version specified in the GO_VERSION file
• The only GitHub Actions still running download_go are Docker actions that cannot use the actions/setup-go GHA
• go-version id is set in the Go Vet workflow, which fixes #5991

The TP_Integration_tests fails, (stil fails after re-running) but because only 1 out of 490 specs failed, I do not think this PR caused the failure. The 1 failure:

2021-07-23T15:28:43.5354179Z 1) Traffic Portal - Origins - Operation Role can login
2021-07-23T15:28:43.5354891Z   Message:
2021-07-23T15:28:43.5360049Z     Failed: No element found using locator: By(css selector, *[id="loginUsername"])

We should open an Issue for the sporadic TP spec failure.

[zrhoffman]

TP Tests passed this time after failing twice in a row.