Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fix maxmind database update and reload#6029

Merged
rob05c merged 1 commit intoapache:masterfrom
ezelkow1:t3c-mmdb-gz
Jul 19, 2021
Merged

Fix maxmind database update and reload#6029
rob05c merged 1 commit intoapache:masterfrom
ezelkow1:t3c-mmdb-gz

Conversation

@ezelkow1
Copy link
Copy Markdown
Member

The plugin and database update do not play nicely when updating via a copy. This change uses a temporary database and a move to make it atomic, then does a touch and reload on remap.config in order to reload the plugin with the new database.

What does this PR (Pull Request) do?

  • This PR fixes #REPLACE_ME OR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • Traffic Ops ORT

What is the best way to verify this PR?

Set the date back on a maxmind database on a cache. Run t3c and verify that it updates as it should and that an ATS reload is initiated

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

The plugin and database update do not play nicely when updating via a copy. This change uses a temporary database and a move to make it atomic, then does a touch and reload on remap.config in order to reload the plugin with the new database.
@ocket8888 ocket8888 added the cache-config Cache config generation label Jul 15, 2021
Copy link
Copy Markdown
Contributor

@jrushford jrushford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested on a cache server belonging to the company for which I work, works as designed.

@rob05c rob05c merged commit 08e4439 into apache:master Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cache-config Cache config generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants