This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix traffic_portal audit issues and remove un-needed deps#6514
Merged
ocket8888 merged 3 commits intoapache:masterfrom Jan 21, 2022
Merged
Fix traffic_portal audit issues and remove un-needed deps#6514ocket8888 merged 3 commits intoapache:masterfrom
ocket8888 merged 3 commits intoapache:masterfrom
Conversation
ocket8888
reviewed
Jan 21, 2022
ocket8888
approved these changes
Jan 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the 22 vulnerabilities (12 high, 3 critical) found by
npm audit. It also removes TP dependencies that are not used.Changelogs for updates (all breaking changes are not relevant):
bootstrap-sass, es5-shim, express, font-awesome, grunt-brwoserify, grunt-html2js, grunt, json3, load-grunt-config, sass, time-grunt
Removed:
grunt-concurrent,grunt-contrib-concat,grunt-contrib-cssmin,grunt-contrib-jsmin,grunt-contrib-uglify,grunt-contrib-htmlmin,grunt-newer,grunt-contrib-jshintandgrunt-wiredepNote:
t_p/app/src/package.jsoncontains the required node_modules to run the server portion of TP.t_p/app/package.jsonalso needs these deps for the build process even though it's not actually needed for the front end. As such the versions of these two files should always match.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Build TP in both dev and prod mode. Verify both still work, run tests and make sure they still work. Verify
npm auditreturns 0 issues.If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist