Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fix traffic_portal audit issues and remove un-needed deps#6514

Merged
ocket8888 merged 3 commits intoapache:masterfrom
shamrickus:tp/upgrade-deps
Jan 21, 2022
Merged

Fix traffic_portal audit issues and remove un-needed deps#6514
ocket8888 merged 3 commits intoapache:masterfrom
shamrickus:tp/upgrade-deps

Conversation

@shamrickus
Copy link
Copy Markdown
Member

@shamrickus shamrickus commented Jan 19, 2022

This PR fixes the 22 vulnerabilities (12 high, 3 critical) found by
npm audit. It also removes TP dependencies that are not used.

Changelogs for updates (all breaking changes are not relevant):
bootstrap-sass, es5-shim, express, font-awesome, grunt-brwoserify, grunt-html2js, grunt, json3, load-grunt-config, sass, time-grunt

Removed:
grunt-concurrent, grunt-contrib-concat, grunt-contrib-cssmin, grunt-contrib-jsmin, grunt-contrib-uglify, grunt-contrib-htmlmin, grunt-newer, grunt-contrib-jshint and grunt-wiredep

Note: t_p/app/src/package.json contains the required node_modules to run the server portion of TP. t_p/app/package.json also needs these deps for the build process even though it's not actually needed for the front end. As such the versions of these two files should always match.


Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Build TP in both dev and prod mode. Verify both still work, run tests and make sure they still work. Verify npm audit returns 0 issues.

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

@shamrickus shamrickus added bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1 dependencies Pull requests that update a dependency file labels Jan 19, 2022
@ocket8888 ocket8888 self-assigned this Jan 21, 2022
@ocket8888 ocket8888 merged commit d414008 into apache:master Jan 21, 2022
@shamrickus shamrickus deleted the tp/upgrade-deps branch January 21, 2022 21:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended dependencies Pull requests that update a dependency file Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants