This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Use github.com/lestrrat-go/jwx/jwt for JWT#6641
Merged
mattjackson220 merged 9 commits intoapache:masterfrom Mar 23, 2022
Merged
Use github.com/lestrrat-go/jwx/jwt for JWT#6641mattjackson220 merged 9 commits intoapache:masterfrom
mattjackson220 merged 9 commits intoapache:masterfrom
Conversation
zrhoffman
added
Traffic Ops
ocket8888
reviewed
Mar 15, 2022
Contributor
ocket8888
left a comment
ocket8888
left a comment
There was a problem hiding this comment.
I think I'd feel most comfortable merging this if @mattjackson220 gave it his stamp of approval
zrhoffman
force-pushed
the
no-github.com/dgrijalva/jwt-go
branch
from
4d2feb7 to
a012d6f
Compare
Member
Author
|
Rebased due to a conflict with |
Contributor
|
I re-ran the |
zrhoffman
force-pushed
the
no-github.com/dgrijalva/jwt-go
branch
from
ef0abcd to
7f69760
Compare
* updated token parsing with new library * fixed per comment
zrhoffman
force-pushed
the
no-github.com/dgrijalva/jwt-go
branch
from
d150457 to
588a913
Compare
Member
Author
|
Rebased onto master to get #6679 |
mattjackson220
approved these changes
Mar 23, 2022
Contributor
mattjackson220
left a comment
mattjackson220
left a comment
There was a problem hiding this comment.
Looks good! tested locally and works as expected! one test is failing but not due to this PR so this is all good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-up PR to #6434, this PR refactors the JWT parts of #6524 and #6577 to use github.com/lestrrat-go/jwx/jwt and removes the now-unused github.com/dgrijalva/jwt-go dependency.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
PR submission checklist