Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

t3c ATS RPM: Enable software collections environment before building OpenSSL#6680

Open
zrhoffman wants to merge 2 commits intoapache:masterfrom
zrhoffman:t3c-tests-rhel-7-fix
Open

t3c ATS RPM: Enable software collections environment before building OpenSSL#6680
zrhoffman wants to merge 2 commits intoapache:masterfrom
zrhoffman:t3c-tests-rhel-7-fix

Conversation

@zrhoffman
Copy link
Member

@zrhoffman zrhoffman commented Mar 22, 2022

This PR gets building the Cache Config Integration Tests's configuration for a CentOS 7 ATS RPM to work again by enabling the newer GCC version before trying to build OpenSSL and using the OS_DISTRO and OS_VERSION values set when the Docker image is built.


Which Traffic Control components are affected by this PR?

  • Traffic Control Cache Config (t3c, formerly ORT) - integration tests ATS RPM build configuration

What is the best way to verify this PR?

Verify that building the ATS RPM for CentOS 7 passes:

export OS_DISTRO=centos OS_VERSION=7
cd cache-config/testing/docker
docker-compose -f docker-compose-ats-build.yml build
docker-compose -f docker-compose-ats-build.yml up

PR submission checklist

@zrhoffman zrhoffman added bug something isn't working as intended Traffic Server related to Apache Traffic Server tests related to tests and/or testing infrastructure build related to the build process cache-config Cache config generation os labels Mar 22, 2022
@zrhoffman zrhoffman changed the title Enable software collections environment before building OpenSSL t3c ATS RPM: Enable software collections environment before building OpenSSL Mar 23, 2022
@zrhoffman zrhoffman force-pushed the t3c-tests-rhel-7-fix branch from bf604c2 to 41fa447 Compare March 23, 2022 14:14
@ocket8888
Copy link
Contributor

Should we change the t3c tests to a matrix of the two OSes ? Right now this may fix it, but the default is to use Rocky 8 so the GHAs don't tell me if it's fixed.

@zrhoffman
Copy link
Member Author

Apache asks projects not to use the matrix execution strategy on PRs, due to the concurrent job limit for the whole Apache org:

My proposal is to create a GitHub Action that will allow to run only a
subset of "matrix" test for PRs that are not yet approved by committers.

So we could do matrix on the master branch as long as we don't do it on PRs.

@ocket8888
Copy link
Contributor

Well a matrix would be easiest, but if we shouldn't do that should it at least test them both sequentially?

@zrhoffman
Copy link
Member Author

That would probably be okay

@zrhoffman
Copy link
Member Author

How would you do it sequentially, though, without having the job be twice as long?

@ocket8888
Copy link
Contributor

You wouldn't, which is what I mean about matrix being the easiest way.

@zrhoffman
Copy link
Member Author

Rocky Linux 8 is already well-tested in the T3C Integration Tests, CDN-in-a-Box CI, and TC Health Client Integration Tests workflows. How about a CentOS 7-only workflow that builds the ATS RPM whenever files in that directory (or the dockerfile) are changed?

Then we wouldn't need matrix.

@ocket8888
Copy link
Contributor

Sure, that's fine by me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended build related to the build process cache-config Cache config generation os tests related to tests and/or testing infrastructure Traffic Server related to Apache Traffic Server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants