This repository was archived by the owner on Nov 24, 2025. It is now read-only.
fixed JWT Auth to have Expires and renew when Mojo renews#6745
Merged
srijeet0406 merged 1 commit intoapache:masterfrom Apr 20, 2022
Merged
fixed JWT Auth to have Expires and renew when Mojo renews#6745srijeet0406 merged 1 commit intoapache:masterfrom
srijeet0406 merged 1 commit intoapache:masterfrom
Conversation
mattjackson220
added
bug
srijeet0406
approved these changes
Apr 20, 2022
Contributor
srijeet0406
left a comment
srijeet0406
left a comment
There was a problem hiding this comment.
Code looks good.
Unit tests and API tests pass.
Manually tested and verified that the access token's expiry was set to the correct value.
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the JWT Auth to include the Expires field and to renew the token when the mojolicious cookie is renewed
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Login to Traffic Ops and verify that you get a mojolicious cookie and an access_token cookie.
Hit a non-login endpoint and verify that both cookies are refreshed.
Verify that the access_token has the Expired field
Verify that login works as expected using user/pass, mojo cookie, and JWT
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist