This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Add "sharing" ability to CDN locks#6761
Merged
rawlinp merged 8 commits intoapache:masterfrom Apr 27, 2022
Merged
Conversation
Contributor
Contributor
Author
Contributor
Author
|
Hmm, I'm able to create a lock with an |
rawlinp
suggested changes
Apr 22, 2022
traffic_ops/app/db/migrations/2022031622271100_add_user_sharing_cdn_locks.up.sql
Outdated
Show resolved
Hide resolved
traffic_ops/app/db/migrations/2022031622271100_add_user_sharing_cdn_locks.down.sql
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/modules/dialog/select/lock/dialog.select.lock.tpl.html
Outdated
Show resolved
Hide resolved
b41d70f to
a4e3bbe
Compare
11585c0 to
5103476
Compare
rawlinp
approved these changes
Apr 27, 2022
Contributor
rawlinp
left a comment
There was a problem hiding this comment.
We can probably make the UI options list for selecting shared users better, but it works for a first pass at it.
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
* adding changes for cdn locks to be shared * Adding docs * fix query, docs, changelog * address code review comments * code review fixes * add blank line * fix unit tests * missed committing one file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR is not related to any issue. It adds the ability to CDN locks, so that they can be shared amongst multiple users.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run TO and TP locally.
As user A, acquire the lock on CDN X.
In the shared usernames field, type in the username of another user that has a tenancy of lesser than or equal to that of user A.
Make sure you can do all the activities on CDN X as user B, as you would have been able to as user A.
Make sure that user A cannot share their lock with a user that has a higher tenancy level than itself, or with a user that doesn't exist in the database.
Make sure all the tests pass.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist