This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix t3c peering ring strategy generation for topologies, add tests#6809
Merged
zrhoffman merged 1 commit intoapache:masterfrom May 23, 2022
Merged
Conversation
rob05c
added
bug
rob05c
changed the title
ezelkow1
approved these changes
May 19, 2022
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I set out to add tests for the new (experimental) Peering Ring Strategy generation, and discovered it wasn't generating right for Delivery Services with Topologies.
So this includes the fix to generate peering ring strategies for topologies, as well as tests for both topology and non-topology DSes.
Which Traffic Control components are affected by this PR?
t3c, formerly ORT)What is the best way to verify this PR?
Run tests. Generate config with the new experimental peering ring strategy parameter, for both DSes with and without topologies, verify strategies file contains peering ring directives.
If this is a bugfix, which Traffic Control versions contained the bug?
Not in a release.
PR submission checklist
[x] This PR has documentationno docs, feature is experimental[x] This PR has a CHANGELOG.md entryno changelog, bug was not in a release