This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Merged
Conversation
1 task
rob05c
force-pushed
the
cleanup-parent-symbols-plus-t3c-profile-layering
branch
from
ae88233 to
a06eab0
Compare
traeak
approved these changes
May 13, 2022
Contributor
traeak
left a comment
traeak
left a comment
There was a problem hiding this comment.
Code looks fine. This doesn't appear to break existing behavior.
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds cache config profile layering
Which Traffic Control components are affected by this PR?
t3c, formerly ORT)What is the best way to verify this PR?
Run tests. TO won't allow users to assign multiple profiles until the next version, so other than tests, there isn't a good way to manually verify this, other than hand-crafting the JSON and calling t3c-generate. Or maybe putting hand-crafted JSON in the t3c cache file.
If this is a bugfix, which Traffic Control versions contained the bug?
Not a bug fix.
PR submission checklist
[x] This PR has documentationno docs, no interface change[x] This PR has a CHANGELOG.md entryno changelog, no interface change