This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Convert Delivery Services table to use "common" grid controller#6989
Merged
shamrickus merged 3 commits intoapache:masterfrom Aug 2, 2022
Merged
Convert Delivery Services table to use "common" grid controller#6989shamrickus merged 3 commits intoapache:masterfrom
shamrickus merged 3 commits intoapache:masterfrom
Conversation
ocket8888
added
Traffic Portal v1
shamrickus
reviewed
Aug 1, 2022
Member
shamrickus
left a comment
shamrickus
left a comment
There was a problem hiding this comment.
Code changes look good, I think the failing test may be related though.
Member
|
This broke several tables that extended The |
shamrickus
pushed a commit
that referenced
this pull request
Aug 17, 2022
* Fix grids using an empty string for table titles * Convert Delivery Services table to use common grid controller * Fix tests looking for a link that's now a button
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
…he#6989) * Fix grids using an empty string for table titles * Convert Delivery Services table to use common grid controller * Fix tests looking for a link that's now a button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts the Delivery Services table from using a copy/pasted AG-Grid implementation to using an embedded "common" grid controller.
I also fixed an issue where tables that set the title directly instead of using breadcrumbs had no title.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
The functionality should be fully replicated, so just make sure the existing tests still pass.
PR submission checklist