This repository was archived by the owner on Nov 24, 2025. It is now read-only.
t3c integration tests to not modify config file#7028
Merged
rob05c merged 2 commits intoapache:masterfrom Aug 19, 2022
Merged
Conversation
ocket8888
added
low impact
rob05c
approved these changes
Aug 19, 2022
Member
rob05c
left a comment
rob05c
left a comment
There was a problem hiding this comment.
LGTM. Ran tests, they passed, no local files were modified.
Thanks for this! This has been annoying me for ages
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
* write tc-fixtures.json to tmp file and move to container * use tc-fixtures.json from container
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the Cache Config Integration Test framework modifies cache-config/ort-tests/tc-fixtures.json with the ATS RPM version before running. Because this file is checked into git, this creates a git change. It means developers have to revert the file before committing, commit -A, can accidentally commit the file with the injected RPM info, etc.
Which Traffic Control components are affected by this PR?
t3c, formerly ORT)What is the best way to verify this PR?
Run t3c integration tests and see that tc-fixtures.json is not modified.
If this is a bugfix, which Traffic Control versions contained the bug?
Not a bug fix.
PR submission checklist