This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Made Clear Table Filters option visible to the user#7088
Merged
zrhoffman merged 2 commits intoapache:masterfrom Sep 28, 2022
Merged
Made Clear Table Filters option visible to the user#7088zrhoffman merged 2 commits intoapache:masterfrom
Clear Table Filters option visible to the user#7088zrhoffman merged 2 commits intoapache:masterfrom
Conversation
…t to column selector.
rimashah25
changed the title
clear table filter option visible to the userClear Table Filters option visible to the user
zrhoffman
added
Traffic Portal v1
zrhoffman
suggested changes
Sep 27, 2022
Member
zrhoffman
left a comment
zrhoffman
left a comment
There was a problem hiding this comment.
Adding the filter icon seems like an improvement, but I'm not sure it should replace the Table Filters text. Maybe the icon comes before or after Clear Table Filters?
Member
|
On second thought, having the button always visible like this makes it obvious enough to a user who doesn't know what the filter icon is, and as long as the help text is descriptive, the button text itself seems sufficient as-is |
zrhoffman
suggested changes
Sep 28, 2022
traffic_portal/app/src/common/modules/table/agGrid/grid.tpl.html
Outdated
Show resolved
Hide resolved
.../app/src/common/modules/table/deliveryServiceRequests/table.deliveryServiceRequests.tpl.html
Outdated
Show resolved
Hide resolved
zrhoffman
approved these changes
Sep 28, 2022
Member
zrhoffman
left a comment
zrhoffman
left a comment
There was a problem hiding this comment.
Looks good! I'll merge once the tests pass.
4 tasks
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
* Removed `clear table filter` option from the More menu and placed next to column selector. * Updated title for clear filter button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #7055
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
All pages that use ag-grid (like DS, DS requests, servers , profiles etc) should now show this button:
Note: Functionality of the
clear table filterbutton hasn't change only its placement.If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist