This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Consider DS Regional field for MaxOriginConnections of Edge Caches#7160
Merged
ocket8888 merged 4 commits intoapache:masterfrom Oct 27, 2022
Merged
Consider DS Regional field for MaxOriginConnections of Edge Caches#7160ocket8888 merged 4 commits intoapache:masterfrom
ocket8888 merged 4 commits intoapache:masterfrom
Conversation
zrhoffman
added
bug
jpappa200
approved these changes
Oct 26, 2022
Contributor
jpappa200
left a comment
jpappa200
left a comment
There was a problem hiding this comment.
👍 LGTM and tests ran successfully.
ocket8888
added
the
low impact
zrhoffman
added
medium impact
ocket8888
suggested changes
Oct 27, 2022
ocket8888
approved these changes
Oct 27, 2022
Contributor
ocket8888
left a comment
ocket8888
left a comment
There was a problem hiding this comment.
Will merge pending actions success
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where MaxOriginConnections for a Regional Delivery Service was not divided over a Server's own Cache Group in the case of Edge Caches directly parented by the Origin.
This PR also fixes the logic for the Regional MaxOriginConnections for Mid Caches by moving it to the correct block and updating tests.
Which Traffic Control components are affected by this PR?
t3c, formerly ORT)What is the best way to verify this PR?
Run the t3c integration tests and the t3c and
lib/go-atscfgintegration testsIf this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist