Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

dep(run-ciab): update from Node12 to Node16#7177

Merged
zrhoffman merged 2 commits intoapache:masterfrom
devenes:patch-1
Nov 7, 2022
Merged

dep(run-ciab): update from Node12 to Node16#7177
zrhoffman merged 2 commits intoapache:masterfrom
devenes:patch-1

Conversation

@devenes
Copy link
Contributor

@devenes devenes commented Nov 7, 2022

The GitHub Actions workflow gives the following annotation while running the action:

Node.js 12 actions are deprecated. For more information see: github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12.

Signed-off-by: Enes ahmedenesturan@gmail.com


Which Traffic Control components are affected by this PR?

  • run-ciab GitHub Actions

What is the best way to verify this PR?

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

The GitHub Actions workflow gives the following annotation while running the action:
Node.js 12 actions are deprecated. For more information see: github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12.
@zrhoffman zrhoffman added improvement The functionality exists but it could be improved in some way. automation related to automated testing/deployment/packaging etc. dependencies Pull requests that update a dependency file labels Nov 7, 2022
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Enes <ahmedenesturan@gmail.com>
@devenes
Copy link
Contributor Author

devenes commented Nov 7, 2022

This looks good so far. Would you mind updating the other actions, too?

Thanks for your review! Updated deprecated actions.

Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for your contribution!

@zrhoffman zrhoffman merged commit 52414a1 into apache:master Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automation related to automated testing/deployment/packaging etc. dependencies Pull requests that update a dependency file improvement The functionality exists but it could be improved in some way.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants