This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Merged
Conversation
shamrickus
added
new feature
ocket8888
added
the
low impact
ocket8888
reviewed
Nov 21, 2022
ocket8888
reviewed
Nov 21, 2022
...ental/traffic-portal/src/app/core/cache-groups/divisions/detail/division-detail.component.ts
Show resolved
Hide resolved
ocket8888
approved these changes
Nov 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the Divisions table & edit pages to TPv2. It also updates nightwatch and loosens versioning restriction in
package.jsonto allow for up-to minor version updates.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Ensure that both the table (
/core/divisions) and detail (/core/divisions/:id) pages both work and match the functionality of what is found in v1.PR submission checklist