This repository was archived by the owner on Nov 24, 2025. It is now read-only.
use a comma separated list of IPs for purge_allow_ip#7233
Merged
ocket8888 merged 4 commits intoapache:masterfrom Dec 14, 2022
Merged
use a comma separated list of IPs for purge_allow_ip#7233ocket8888 merged 4 commits intoapache:masterfrom
ocket8888 merged 4 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7233 +/- ##
=========================================
Coverage ? 24.63%
=========================================
Files ? 422
Lines ? 62600
Branches ? 0
=========================================
Hits ? 15424
Misses ? 45650
Partials ? 1526
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ocket8888
reviewed
Dec 8, 2022
Contributor
ocket8888
left a comment
There was a problem hiding this comment.
FWIW, separating by lines may be easier to read, and is pretty unix-like-standard. Just one man's opinion.
traeak
approved these changes
Dec 14, 2022
Contributor
traeak
left a comment
There was a problem hiding this comment.
Looks okay. Document does mention to use a parameter with comma separated ips to specify multiple addresses.
ocket8888
approved these changes
Dec 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #7232
If a profile has multiple parameters with the same name and config file, the layered profile approach will only use one parameter. this has become an issue with ip_allow.yaml because we add multiple single IPs to allow purge from all Traffic Ops servers.
I have updated ipallowdotyaml.go to handle a comma separated list of IP addresses in a single parameter.
Which Traffic Control components are affected by this PR?
t3c, formerly ORT)What is the best way to verify this PR?
create a parameter Name: purge_allow_ip Config File: ip_allow.config Value: comma separated list of IPs. associate new parameter with a profile and remove all other purge_allow_ip parameters. Queue updates and run t3c. when finished you should see all IPs allowing purge and if you queue and run again ip_allow.yaml doesn't change.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist