Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@ocket8888
Copy link
Contributor

The APIv5 handler for creating Delivery Service Requests to delete a Delivery Service currently attempts to cast the structure to a v4 DSR struct, which results in a false validation failure. This PR fixes that.


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

  1. Make a DS
  2. Create a DSR to delete that DS and make sure that succeeds.

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

  • This PR has tests
  • This PR doesn't need documentation
  • This PR doesn't need a CHANGELOG.md entry
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added bug something isn't working as intended Traffic Ops related to Traffic Ops medium impact impacts a significant portion of a CDN, or has the potential to do so labels Dec 16, 2022
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #7256 (0e2f841) into master (20882f7) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #7256   +/-   ##
=========================================
  Coverage     28.29%   28.29%           
  Complexity       98       98           
=========================================
  Files           617      617           
  Lines         69363    69363           
  Branches         90       90           
=========================================
  Hits          19626    19626           
  Misses        47925    47925           
  Partials       1812     1812           
Flag Coverage Δ
golib_unit 52.87% <ø> (ø)
grove_unit 4.60% <ø> (ø)
t3c_generate_unit 24.96% <ø> (ø)
traffic_monitor_unit 20.43% <ø> (ø)
traffic_ops_integration 69.41% <ø> (ø)
traffic_ops_unit 19.75% <0.00%> (ø)
traffic_stats_unit 10.41% <ø> (ø)
v3 57.68% <ø> (ø)
v4 79.65% <ø> (ø)
v5 78.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...fic_ops_golang/deliveryservice/request/validate.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@rimashah25 rimashah25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am able to delete a DS via DSR and don't see the previous error original: expected a Delivery Service, got *tc.DeliveryServiceV50.

@srijeet0406 srijeet0406 merged commit bf961a6 into apache:master Dec 16, 2022
@ocket8888 ocket8888 deleted the to/delete-dsr-creation-fix branch December 16, 2022 18:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended medium impact impacts a significant portion of a CDN, or has the potential to do so Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants