Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Use golang docker image#7266

Merged
zrhoffman merged 5 commits intoapache:masterfrom
ericholguin:use-golang-docker
Jan 9, 2023
Merged

Use golang docker image#7266
zrhoffman merged 5 commits intoapache:masterfrom
ericholguin:use-golang-docker

Conversation

@ericholguin
Copy link
Contributor

Replace go install with the golang docker image


Which Traffic Control components are affected by this PR?

  • Docker images

What is the best way to verify this PR?

Build docker images and verify they are still working

PR submission checklist

Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Would you mind doing tools/golang/Dockerfile too?

@zrhoffman zrhoffman added tech debt rework due to choosing easy/limited solution automation related to automated testing/deployment/packaging etc. go version labels Jan 5, 2023
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests pass!

@zrhoffman zrhoffman merged commit 40e7d68 into apache:master Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automation related to automated testing/deployment/packaging etc. go version tech debt rework due to choosing easy/limited solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants