This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Docker go tests runners: Unwrap commands from bash shell to inherit environment variables#7281
Merged
ocket8888 merged 2 commits intoapache:masterfrom Jan 11, 2023
Merged
Docker go tests runners: Unwrap commands from bash shell to inherit environment variables#7281ocket8888 merged 2 commits intoapache:masterfrom
ocket8888 merged 2 commits intoapache:masterfrom
Conversation
…nvironment variables
zrhoffman
added
Traffic Ops
ericholguin
approved these changes
Jan 10, 2023
Contributor
ericholguin
left a comment
ericholguin
left a comment
There was a problem hiding this comment.
Ran both tests and both built and got passing results
ocket8888
suggested changes
Jan 11, 2023
ocket8888
approved these changes
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue running the TO or TM unit tests, where
goandGOPATH/binare not in thePATH.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Try to build and run these:
traffic_monitor/tests/Dockerfile-golangtesttraffic_ops/app/bin/tests/Dockerfile-golangtestIf this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist