TPv2 fix login redirect

[ocket8888]

Fixes #7317: Login redirect is broken because it can't handle query string parameters. This PR fixes it so unauthenticated users are directed back where they were trying to go after logging in.

---

Which Traffic Control components are affected by this PR?

• Traffic Portal (experimental v2)

What is the best way to verify this PR?

Assuming you have Traffic Ops running locally on port 6443, run ng serve in the TPv2 directory, then open the URL http://localhost:4200/core/servers?search=test in a new private browsing context (or just any context where you aren't already authenticated). It should send you back to the login page, then after logging in that should take you to the servers table with the search field set to the string "text".

If this is a bugfix, which Traffic Control versions contained the bug?

• master

PR submission checklist

• This PR uses existing tests
• This PR doesn't need documentation
• This PR doesn't need a CHANGELOG.md entry
• This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

[rimashah25]

Issue has been fixed. The dashboard page no longer is seen if the user is unauthorized.

[shamrickus]

This is definitely still broken. Going to any page when unauthenticated will not bring you to the login screen. Not sure if login redirects are still broken as it's not properly moving.

[ocket8888]

Going to any page when authenticated will not bring you to the login screen.

... that's the correct behavior, though, no?

[shamrickus]

when not authenticated, woops edited.

[ocket8888]

I can't reproduce that. I just opened it to http://localhost:4200/core/cdns in a new private browsing context and got redirected to login. What doesn't work is actually redirecting afterwards. Since the core module isn't loaded until after authentication, there is no routing available under /core/ at the time that the user logs in, so it can't navigate.

[shamrickus]

I think you are correct, the issue I was seeing occurs when you leave TP open and let the cookie expire naturally. It will then redirect the user to https://{TPURL}, which is just a blank screen with the sidebar shown as opposed to the login screen.