-
Notifications
You must be signed in to change notification settings - Fork 353
Conversation
083ea78 to
c7eeee4
Compare
experimental/traffic-portal/src/app/core/cdns/cdn-detail/cdn-detail.component.ts
Outdated
Show resolved
Hide resolved
ocket8888
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just like in TPv1, this form allows editing the ALL CDN, which - to my chagrin - ought not to be done because that's a special meta object. Similarly, TPv1 allows editing the root tenant (it'll never succeed because the API won't allow it, but the portal itself doesn't stop you from trying), however, in TPv2 you'll notice that all of the fields of the root tenant are read-only.
That's not, strictly speaking, the same situation, because the ALL CDN actually can be successfully updated i.e. the API allows it. Though that's honestly quite dangerous, so I suggest we not allow it through the UI.
experimental/traffic-portal/src/app/core/cdns/cdn-detail/cdn-detail.component.html
Outdated
Show resolved
Hide resolved
experimental/traffic-portal/src/app/core/cdns/cdn-detail/cdn-detail.component.html
Outdated
Show resolved
Hide resolved
3e6585c to
3d3c554
Compare
|
Rebased to get #7363 |
That's a little out-of-scope for creating the CDN details page IMO, let's create a new GH Issue for it. |
experimental/traffic-portal/src/app/core/cdns/cdn-detail/cdn-detail.component.html
Outdated
Show resolved
Hide resolved
experimental/traffic-portal/src/app/core/cdns/cdn-detail/cdn-detail.component.html
Outdated
Show resolved
Hide resolved
|
Rebased to fix conflicts |
3528126 to
3ca9161
Compare
experimental/traffic-portal/src/app/core/cdns/cdn-detail/cdn-detail.component.html
Outdated
Show resolved
Hide resolved
experimental/traffic-portal/src/app/core/cdns/cdn-detail/cdn-detail.component.html
Outdated
Show resolved
Hide resolved
ocket8888
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The form needs error hints but that's systemic to TPv2 so it's unfair to require them in this PR.
This PR adds the Traffic Portal v2 CDN detail page.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run the unit tests and the end-to-end tests
PR submission checklist