parity_statuses table, details #7358

gbkannan89 · 2023-02-22T14:34:06Z

This PR is not related to any issue.

Which Traffic Control components are affected by this PR?

Traffic Portal

What is the best way to verify this PR?

Tried to develop a parity of TPV1 - statuses page.

PR submission checklist

This PR has tests
This PR has documentation
This PR doesn't need a CHANGELOG.md entry
This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

ocket8888

Most - but not all - of your linting errors can be fixed by running ng lint --fix

experimental/traffic-portal/src/app/api/statuses.service.ts

experimental/traffic-portal/src/app/core/statuses/status-details/status-details.component.html

experimental/traffic-portal/src/app/core/statuses/statuses-table/statuses-table.component.ts

experimental/traffic-portal/src/app/core/statuses/statuses-table/statuses-table.module.ts

experimental/traffic-portal/src/app/shared/navigation/navigation.service.ts

experimental/traffic-portal/src/styles.scss

ocket8888

Still has a lot of linting violations. If you've fixed everything that can be automatically fixed with ng lint --fix, ng lint (without --fix) will list the remaining problems for you

experimental/traffic-portal/src/app/api/statuses.service.ts

experimental/traffic-portal/src/app/core/statuses/status-details/status-details.component.html

experimental/traffic-portal/src/app/core/statuses/status-details/status-details.component.ts

...imental/traffic-portal/src/app/core/statuses/statuses-table/statuses-table.component.spec.ts

...imental/traffic-portal/src/app/core/statuses/status-details/status-details.component.spec.ts

experimental/traffic-portal/src/app/core/statuses/statuses-table/statuses-table.component.ts

experimental/traffic-portal/src/styles.scss

experimental/traffic-portal/src/app/core/statuses/status-details/status-details.component.ts

experimental/traffic-portal/src/app/core/statuses/status-details/status-details.component.html

ocket8888

This needs to be rebased on the latest changes in master

experimental/traffic-portal/src/app/api/server.service.ts

experimental/traffic-portal/src/app/core/core.module.ts

experimental/traffic-portal/src/app/api/server.service.ts

experimental/traffic-portal/src/app/core/statuses/status-details/status-details.component.ts

...imental/traffic-portal/src/app/core/statuses/statuses-table/statuses-table.component.spec.ts

...imental/traffic-portal/src/app/core/statuses/status-details/status-details.component.spec.ts

experimental/traffic-portal/src/app/api/server.service.ts

rimashah25

LGTM.

experimental/traffic-portal/src/app/api/server.service.ts

experimental/traffic-portal/src/app/api/testing/server.service.ts

experimental/traffic-portal/src/app/core/core.module.ts

experimental/traffic-portal/src/app/core/statuses/status-details/status-details.component.html

experimental/traffic-portal/src/app/api/server.service.ts

experimental/traffic-portal/src/app/api/testing/server.service.ts

experimental/traffic-portal/src/app/core/statuses/status-details/status-details.component.ts

experimental/traffic-portal/src/app/api/testing/server.service.ts

experimental/traffic-portal/src/app/core/statuses/statuses-table/statuses-table.component.ts

experimental/traffic-portal/src/app/core/statuses/status-details/status-details.component.html

experimental/traffic-portal/src/app/core/statuses/status-details/status-details.component.ts

“kgb488” and others added 2 commits February 21, 2023 21:49

statuses parity - table,details, new,delete

77025d7

Merge branch 'master' into kannan-victory-1

4acb595

gbkannan89 changed the title ~~Kannan victory 1~~ Kannan victory 1 - statuses table, details Feb 22, 2023

ocket8888 added low impact affects only a small portion of a CDN, and cannot itself break one experimental a feature/component not directly supported by ATC Traffic Portal v2 Related to the experimental Traffic Portal version 2 labels Feb 24, 2023

ocket8888 self-assigned this Feb 24, 2023

ocket8888 suggested changes Feb 24, 2023

View reviewed changes

gbkannan89 added 4 commits February 27, 2023 12:27

monu statuses moved under servers

26211f5

breadcrumbs removed,license added,model from lib

057fa66

lint fixes

07869be

lint error fixes

4bcdc44

gbkannan89 requested a review from ocket8888 February 28, 2023 06:30

statuses test cases added

2c9c9cb

ocket8888 added the new feature A new feature, capability or behavior label Mar 1, 2023

ocket8888 suggested changes Mar 1, 2023

View reviewed changes

experimental/traffic-portal/src/app/core/statuses/status-details/status-details.component.ts Outdated Show resolved Hide resolved

experimental/traffic-portal/src/app/core/statuses/status-details/status-details.component.html Outdated Show resolved Hide resolved

gbkannan89 added 4 commits March 6, 2023 11:50

lint fixes

9b2c389

added last line

9e4a8fb

lazy load and statuses service removed

b5ed031

lint error and comments addressed

defc015

gbkannan89 requested a review from ocket8888 March 6, 2023 15:42

ocket8888 suggested changes Mar 6, 2023

View reviewed changes

gbkannan89 and others added 7 commits March 7, 2023 07:16

removed reactive forms module import

97dac47

comments addressed

9703619

statuses parity - table,details, new,delete

dadee3f

monu statuses moved under servers

406c053

breadcrumbs removed,license added,model from lib

8727cea

lint fixes

c0a237a

lint error fixes

64669c7

gbkannan89 added 6 commits April 18, 2023 22:49

e2e test cases added

d2a684f

url corrected

a13384d

added name to fix selector in dom

b05fa6a

e2e test error fix

758314f

added element id and lastdate to dom

9156cb9

error fix

b3af5ec

rimashah25 approved these changes Apr 19, 2023

View reviewed changes

ocket8888 suggested changes Apr 19, 2023

View reviewed changes

gbkannan89 added 2 commits April 25, 2023 06:08

Merge branch 'master' into kannan-victory-1

cfdb3e6

comment addressed

a4fd9fa

gbkannan89 requested a review from ocket8888 April 25, 2023 00:46

ocket8888 suggested changes Apr 25, 2023

View reviewed changes

experimental/traffic-portal/src/app/api/server.service.ts Outdated Show resolved Hide resolved

ocket8888 suggested changes Apr 25, 2023

View reviewed changes

experimental/traffic-portal/src/app/api/testing/server.service.ts Outdated Show resolved Hide resolved

ocket8888 suggested changes Apr 25, 2023

View reviewed changes

experimental/traffic-portal/src/app/core/statuses/status-details/status-details.component.ts Outdated Show resolved Hide resolved

comments addressed

0b59682

gbkannan89 requested a review from ocket8888 April 26, 2023 14:59

ocket8888 suggested changes Apr 26, 2023

View reviewed changes

experimental/traffic-portal/src/app/api/testing/server.service.ts Outdated Show resolved Hide resolved

comment addressed

789cdde

gbkannan89 requested a review from ocket8888 April 26, 2023 17:06

ocket8888 suggested changes Apr 27, 2023

View reviewed changes

experimental/traffic-portal/src/app/core/statuses/statuses-table/statuses-table.component.ts Show resolved Hide resolved

experimental/traffic-portal/src/app/core/statuses/status-details/status-details.component.html Outdated Show resolved Hide resolved

gbkannan89 added 2 commits April 27, 2023 09:04

comment fixed

d3ab71a

Merge branch 'master' into kannan-victory-1

cdedbec

gbkannan89 requested a review from ocket8888 April 27, 2023 03:36

ocket8888 suggested changes Apr 27, 2023

View reviewed changes

experimental/traffic-portal/src/app/core/statuses/status-details/status-details.component.ts Outdated Show resolved Hide resolved

# removed

e3d51d5

gbkannan89 requested a review from ocket8888 April 28, 2023 00:11

ocket8888 approved these changes Apr 28, 2023

View reviewed changes

ocket8888 merged commit 39f4019 into apache:master Apr 28, 2023

gbkannan89 changed the title ~~Kannan victory 1 - statuses table, details~~ parity_statuses table, details May 19, 2023

parity_statuses table, details #7358

parity_statuses table, details #7358

Uh oh!

Conversation

gbkannan89 commented Feb 22, 2023 • edited by ocket8888 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Which Traffic Control components are affected by this PR?

What is the best way to verify this PR?

PR submission checklist

Uh oh!

ocket8888 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ocket8888 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ocket8888 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rimashah25 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gbkannan89 commented Feb 22, 2023 •

edited by ocket8888

Loading