This repository was archived by the owner on Nov 24, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
One of the tests fails ✔ Element <input[name=fuzzControl]> was present after 69 milliseconds.
✔ Passed [ok]: true ok
✖ NightwatchAssertError
Failed [ok]: (The expression evaluated to a falsy value:
assertModule[propName].apply(null, this.args)
) - expected "true" but got: "false" (1ms)
Error location:
/home/runner/work/trafficcontrol/trafficcontrol/experimental/traffic-portal/dist/nightwatch/tests/servers/physLoc/table.spec.js:
–––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––
61 | browser.elements("css selector", "div.ag-row", function (rows) {
62 | browser.assert.ok(rows.status === 0);
63 | browser.assert.ok(rows.value.length >= 2);
64 | });
65 | return [2 /*return*/];
––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––– |
1935ba3 to
a4229b6
Compare
a4229b6 to
439265e
Compare
Codecov Report
@@ Coverage Diff @@
## master #7398 +/- ##
=============================================
+ Coverage 27.12% 61.04% +33.92%
Complexity 98 98
=============================================
Files 685 302 -383
Lines 77421 11535 -65886
Branches 90 779 +689
=============================================
- Hits 20998 7042 -13956
+ Misses 54431 4146 -50285
+ Partials 1992 347 -1645
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 575 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ocket8888
reviewed
Apr 5, 2023
experimental/traffic-portal/src/app/shared/generic-table/generic-table.component.scss
Outdated
Show resolved
Hide resolved
ocket8888
approved these changes
Apr 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
experimental
a feature/component not directly supported by ATC
low impact
affects only a small portion of a CDN, and cannot itself break one
tests
related to tests and/or testing infrastructure
Traffic Portal v2
Related to the experimental Traffic Portal version 2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the TPv2 e2e tests so that they use the sidebar for navigation when possible. It also fixes an issue where the tests weren't idempotent. Finally the tests have been modified so that they will work when pointed at an environment with insecure/self-signed certs. Finally it adds codecov to TPv2
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Ensure the tests pass.
PR submission checklist