Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@shamrickus
Copy link
Member

@shamrickus shamrickus commented Mar 10, 2023

This PR changes the TPv2 e2e tests so that they use the sidebar for navigation when possible. It also fixes an issue where the tests weren't idempotent. Finally the tests have been modified so that they will work when pointed at an environment with insecure/self-signed certs. Finally it adds codecov to TPv2


Which Traffic Control components are affected by this PR?

  • Traffic Portal v2

What is the best way to verify this PR?

Ensure the tests pass.

PR submission checklist

@shamrickus shamrickus added tests related to tests and/or testing infrastructure Traffic Portal v2 Related to the experimental Traffic Portal version 2 labels Mar 10, 2023
@zrhoffman
Copy link
Member

One of the tests fails

   Element <input[name=fuzzControl]> was present after 69 milliseconds.
   Passed [ok]: true ok
   NightwatchAssertError
   Failed [ok]: (The expression evaluated to a falsy value:

  assertModule[propName].apply(null, this.args)
) - expected "true" but got: "false" (1ms)

    Error location:
    /home/runner/work/trafficcontrol/trafficcontrol/experimental/traffic-portal/dist/nightwatch/tests/servers/physLoc/table.spec.js:
    –––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––
     61 |                     browser.elements("css selector", "div.ag-row", function (rows) {
     62 |                         browser.assert.ok(rows.status === 0);
     63 |                         browser.assert.ok(rows.value.length >= 2); 
     64 |                     });
     65 |                     return [2 /*return*/];
    –––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––

@ocket8888 ocket8888 added low impact affects only a small portion of a CDN, and cannot itself break one experimental a feature/component not directly supported by ATC labels Mar 13, 2023
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #7398 (9475dfb) into master (b616c06) will increase coverage by 33.92%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #7398       +/-   ##
=============================================
+ Coverage     27.12%   61.04%   +33.92%     
  Complexity       98       98               
=============================================
  Files           685      302      -383     
  Lines         77421    11535    -65886     
  Branches         90      779      +689     
=============================================
- Hits          20998     7042    -13956     
+ Misses        54431     4146    -50285     
+ Partials       1992      347     -1645     
Flag Coverage Δ
golib_unit ?
grove_unit ?
t3c_unit ?
traffic_monitor_unit ?
traffic_ops_unit ?
traffic_portal_v2 64.22% <ø> (?)
traffic_stats_unit ?
unit_tests 64.22% <ø> (+40.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...al/src/app/shared/navigation/navigation.service.ts 55.81% <ø> (ø)

... and 575 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shamrickus shamrickus requested a review from ocket8888 March 27, 2023 21:38
@ocket8888 ocket8888 self-assigned this Apr 5, 2023
@ocket8888 ocket8888 merged commit 6a4bc56 into apache:master Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

experimental a feature/component not directly supported by ATC low impact affects only a small portion of a CDN, and cannot itself break one tests related to tests and/or testing infrastructure Traffic Portal v2 Related to the experimental Traffic Portal version 2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants