Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@gokulakrishnansvm
Copy link
Contributor

@gokulakrishnansvm gokulakrishnansvm commented Mar 13, 2023

Adding API Contract Test for cdns endpoint in Traffic Ops V4


Which Traffic Control components are affected by this PR?

  • Traffic Ops Test

What is the best way to verify this PR?

Step 1 : Install requirements
pip install -r requirements.txt

Step 2 : To execute cdn API Contract Testcase , navigate to traffic_ops/testing/api_contract/v4
pytest --to-user Username --to-password Password --to-url URL test_cdns.py

PR submission checklist

Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to check the code against our linter configuration at traffic_control/clients/python/pylint.rc

@ocket8888 ocket8888 added new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops tests related to tests and/or testing infrastructure low impact affects only a small portion of a CDN, and cannot itself break one labels Mar 13, 2023
@gokulakrishnansvm
Copy link
Contributor Author

Don't forget to check the code against our linter configuration at traffic_control/clients/python/pylint.rc

checked the code against pylint.

Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like your Python source files are using spaces in place of real indentation. That needs to be fixed - and should be resulting in an extremely low pylint score.

Also, what happens to uncaught exceptions in the tests? Does it crash testing, or just mark a single test as a failure or what?

Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like your Python source files are using spaces in place of real indentation. That needs to be fixed - and should be resulting in an extremely low pylint score.

Also, what happens to uncaught exceptions in the tests? Does it crash testing, or just mark a single test as a failure or what?

@ocket8888 ocket8888 self-assigned this Mar 20, 2023
Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

@ocket8888 ocket8888 merged commit 048711c into apache:master Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

low impact affects only a small portion of a CDN, and cannot itself break one new feature A new feature, capability or behavior tests related to tests and/or testing infrastructure Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants