-
Notifications
You must be signed in to change notification settings - Fork 353
Adding API Contract Test for cdns endpoint #7400
Adding API Contract Test for cdns endpoint #7400
Conversation
ocket8888
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to check the code against our linter configuration at traffic_control/clients/python/pylint.rc
checked the code against pylint. |
ocket8888
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like your Python source files are using spaces in place of real indentation. That needs to be fixed - and should be resulting in an extremely low pylint score.
Also, what happens to uncaught exceptions in the tests? Does it crash testing, or just mark a single test as a failure or what?
ocket8888
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like your Python source files are using spaces in place of real indentation. That needs to be fixed - and should be resulting in an extremely low pylint score.
Also, what happens to uncaught exceptions in the tests? Does it crash testing, or just mark a single test as a failure or what?
ocket8888
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me.
Adding API Contract Test for cdns endpoint in Traffic Ops V4
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Step 1 : Install requirements
pip install -r requirements.txt
Step 2 : To execute cdn API Contract Testcase , navigate to traffic_ops/testing/api_contract/v4
pytest --to-user Username --to-password Password --to-url URL test_cdns.py
PR submission checklist
This PR has tests
This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)