Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@kdamichie
Copy link
Contributor

This PR is not related to any issue. It increases the test coverage for files under the crconfig folder in Traffic Ops.


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Make sure all the unit tests pass

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #7401 (cdef2b1) into master (ea5099d) will increase coverage by 1.30%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7401      +/-   ##
============================================
+ Coverage     26.16%   27.46%   +1.30%     
  Complexity       98       98              
============================================
  Files           648      394     -254     
  Lines         76195    45669   -30526     
  Branches         90       90              
============================================
- Hits          19934    12542    -7392     
+ Misses        54422    32057   -22365     
+ Partials       1839     1070     -769     
Flag Coverage Δ
golib_unit ?
grove_unit ?
t3c_unit ?
traffic_monitor_unit ?
traffic_ops_integration 69.42% <ø> (+0.07%) ⬆️
traffic_ops_unit 21.24% <ø> (+1.54%) ⬆️
traffic_stats_unit ?
unit_tests 21.24% <ø> (-1.36%) ⬇️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (+0.09%) ⬆️
v5 78.63% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 271 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rimashah25 rimashah25 self-requested a review March 13, 2023 20:33
Copy link
Contributor

@rimashah25 rimashah25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

@rimashah25 rimashah25 merged commit af86550 into apache:master Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants