This repository was archived by the owner on Nov 24, 2025. It is now read-only.
TPv2 API services tech debt #7421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocket8888
added
low impact
Member
|
This will need to be rebased as next time the E2E tests will fail due to chrome version mismatch |
ocket8888
force-pushed
the
tpv2/api-tech-debt
branch
from
17fb49b to
e7855fa
Compare
Also improved base class test coverage to 100%
… to delete divisions directly Also expanded test coverage of the CG service to 100%
Also added 100% test coverage
Also expand test coverage to 100%
Also simplify an operation in the DS component where only data is required
also added 100% test coverage
Also added the ability to directly delete a Job instead of requiring the caller to dereference that for us. Also improved test coverage to 100%.
Also adds 100% test coverage
…nger necessary) Also added 100% test coverage
…onses Also fixed a bug where it was impossible to get a single status. Also also added 100% test coverage and JSDocs for all of the overload signatures.
Also add 100% test coverage
… user also removed the "ability" to get a Role by ID - which is something Roles no longer have. Also also added JSDoc comments for all overloads. Also also also added 100% test coverage.
ocket8888
force-pushed
the
tpv2/api-tech-debt
branch
from
e7855fa to
680c102
Compare
Codecov Report
@@ Coverage Diff @@
## master #7421 +/- ##
============================================
+ Coverage 61.11% 65.44% +4.32%
Complexity 98 98
============================================
Files 305 305
Lines 11674 11616 -58
Branches 795 788 -7
============================================
+ Hits 7135 7602 +467
+ Misses 4191 3667 -524
+ Partials 348 347 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 100% test coverage to the API services in TPv2, primarily. It also adds an overload signature or two, some overload JSDoc comments, and fixes a couple bugs I encountered while writing the tests.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure the new unit tests pass. Verify 100% coverage with
ng test --code-coverage(note the testing services have no such promise of coverage (yet)).PR submission checklist