Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@gbkannan89
Copy link
Contributor

This PR add profiles table page parity TPv2 primarily. It includes delete, export & view servers options. I have not included features like create, edit, import, compare, clone profile, view delivery services ans manage parameters as those features come under other tickets.

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

  • Make sure the unit tests pass withng test

PR submission checklist

@ocket8888 ocket8888 self-assigned this Apr 10, 2023
@ocket8888 ocket8888 added new feature A new feature, capability or behavior low impact affects only a small portion of a CDN, and cannot itself break one experimental a feature/component not directly supported by ATC Traffic Portal v2 Related to the experimental Traffic Portal version 2 labels Apr 10, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #7434 (af60510) into master (8eace3b) will increase coverage by 0.07%.
The diff coverage is 82.60%.

@@             Coverage Diff              @@
##             master    #7434      +/-   ##
============================================
+ Coverage     61.05%   61.13%   +0.07%     
  Complexity       98       98              
============================================
  Files           302      303       +1     
  Lines         11535    11581      +46     
  Branches        779      784       +5     
============================================
+ Hits           7043     7080      +37     
- Misses         4146     4154       +8     
- Partials        346      347       +1     
Flag Coverage Δ
traffic_portal_v2 64.42% <82.60%> (+0.18%) ⬆️
unit_tests 64.42% <82.60%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntal/traffic-portal/src/app/api/profile.service.ts 5.55% <0.00%> (-2.14%) ⬇️
...al/src/app/shared/navigation/navigation.service.ts 55.81% <ø> (ø)
...ffic-portal/src/app/api/testing/profile.service.ts 73.91% <80.00%> (+4.68%) ⬆️
.../profiles/profile-table/profile-table.component.ts 96.77% <96.77%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shamrickus
Copy link
Member

This will need to be rebased as next time the E2E tests will fail due to chrome version mismatch

Copy link
Member

@shamrickus shamrickus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also have E2E tests under the nightwatch folder. You can look at the other tables to see how it's done, our E2E tests are lacking right now so it shouldn't be too much effort.

@gbkannan89 gbkannan89 requested a review from shamrickus April 15, 2023 04:38
Copy link
Member

@shamrickus shamrickus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Code looks good and runs appropriately, any missing features are planned for the profile detail/parameters PRs.

data.type = respType;

const profile: RequestProfile = {
cdn: 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would prefer this to use respCDN.id so that the tests work regardless of what the environment currently looks like; however, CDN 1 is the ALL CDN which is not able to be deleted so this is fine and should always work.

@shamrickus shamrickus merged commit 54e509b into apache:master Apr 18, 2023
@gbkannan89 gbkannan89 changed the title Yuengling profile table parity profile table parity May 19, 2023
@gbkannan89 gbkannan89 changed the title profile table parity parity_profile table parity May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

experimental a feature/component not directly supported by ATC low impact affects only a small portion of a CDN, and cannot itself break one new feature A new feature, capability or behavior Traffic Portal v2 Related to the experimental Traffic Portal version 2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants