-
Notifications
You must be signed in to change notification settings - Fork 353
parity_profile table parity #7434
parity_profile table parity #7434
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7434 +/- ##
============================================
+ Coverage 61.05% 61.13% +0.07%
Complexity 98 98
============================================
Files 302 303 +1
Lines 11535 11581 +46
Branches 779 784 +5
============================================
+ Hits 7043 7080 +37
- Misses 4146 4154 +8
- Partials 346 347 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This will need to be rebased as next time the E2E tests will fail due to chrome version mismatch |
shamrickus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also have E2E tests under the nightwatch folder. You can look at the other tables to see how it's done, our E2E tests are lacking right now so it shouldn't be too much effort.
experimental/traffic-portal/src/app/shared/navigation/navigation.service.ts
Outdated
Show resolved
Hide resolved
experimental/traffic-portal/src/app/core/profiles/profile-table/profile-table.component.ts
Show resolved
Hide resolved
experimental/traffic-portal/src/app/core/profiles/profile-table/profile-table.component.html
Show resolved
Hide resolved
experimental/traffic-portal/src/app/api/testing/profile.service.ts
Outdated
Show resolved
Hide resolved
experimental/traffic-portal/src/app/core/profiles/profile-table/profile-table.component.ts
Outdated
Show resolved
Hide resolved
shamrickus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Code looks good and runs appropriately, any missing features are planned for the profile detail/parameters PRs.
| data.type = respType; | ||
|
|
||
| const profile: RequestProfile = { | ||
| cdn: 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I would prefer this to use respCDN.id so that the tests work regardless of what the environment currently looks like; however, CDN 1 is the ALL CDN which is not able to be deleted so this is fine and should always work.
This PR add profiles table page parity TPv2 primarily. It includes delete, export & view servers options. I have not included features like create, edit, import, compare, clone profile, view delivery services ans manage parameters as those features come under other tickets.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
ng testPR submission checklist