Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@shamrickus
Copy link
Member

This PR fixes an issue with the TPv2 e2e container. It also adds a config file to nightwatch such that it can be edited instead of manually editing source files and jq can be used. It also adds some timeout options to the nightwatch conf that are set to the default values for the purpose of modifying if any CI systems need longer timeouts.


Which Traffic Control components are affected by this PR?

  • Traffic Portal v2
  • CDN in a Box

What is the best way to verify this PR?

Run the TPv2 e2e container and verify that it succeeds.

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

@shamrickus shamrickus added bug something isn't working as intended tests related to tests and/or testing infrastructure cdn-in-a-box related to the Docker-based CDN-in-a-Box system Traffic Portal v2 Related to the experimental Traffic Portal version 2 labels Apr 10, 2023
@shamrickus shamrickus marked this pull request as ready for review April 10, 2023 15:50
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #7440 (d534ff8) into master (096ef2a) will increase coverage by 31.83%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #7440       +/-   ##
=============================================
+ Coverage     29.22%   61.05%   +31.83%     
  Complexity       98       98               
=============================================
  Files           781      302      -479     
  Lines         81527    11535    -69992     
  Branches        779      779               
=============================================
- Hits          23826     7043    -16783     
+ Misses        55653     4146    -51507     
+ Partials       2048      346     -1702     
Flag Coverage Δ
golib_unit ?
grove_unit ?
t3c_unit ?
traffic_monitor_unit ?
traffic_ops_unit ?
traffic_portal_v2 64.24% <ø> (ø)
traffic_stats_unit ?
unit_tests 64.24% <ø> (+38.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 480 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@zrhoffman zrhoffman merged commit 9ac83fe into apache:master Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended cdn-in-a-box related to the Docker-based CDN-in-a-Box system tests related to tests and/or testing infrastructure Traffic Portal v2 Related to the experimental Traffic Portal version 2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants