Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@gokulakrishnansvm
Copy link
Contributor

Added Api contract test case for roles endpoint


Which Traffic Control components are affected by this PR?

  • Traffic Ops Test

What is the best way to verify this PR?

Step 1 : Install requirements
pip install -r requirements.txt

Step 2 : To execute roles API Contract Testcase , navigate to traffic_ops/testing/api_contract/v4
pytest --to-user Username --to-password Password --to-url URL --config Config Path --request-template Request template --response-template Response template test_roles.py

Note: Config, Request template and response template paths are optional.

PR submission checklist

Copy link
Contributor

@ericholguin ericholguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes, everything else looks good. Tests are passing.

Copy link
Contributor

@ericholguin ericholguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shamrickus
Copy link
Member

Merge conflicts

@shamrickus shamrickus merged commit 1acc777 into apache:master Apr 14, 2023
@mitchell852
Copy link
Member

@gokulakrishnansvm can you give this PR a better name. Something like "Added Api contract test case for roles endpoint"

@gokulakrishnansvm gokulakrishnansvm changed the title Api contract roles Added Api contract test case for roles endpoint Apr 27, 2023
@ocket8888 ocket8888 added new feature A new feature, capability or behavior low impact affects only a small portion of a CDN, and cannot itself break one tests related to tests and/or testing infrastructure python Pull requests that update Python or Python-related code Traffic Ops related to Traffic Ops labels Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

low impact affects only a small portion of a CDN, and cannot itself break one new feature A new feature, capability or behavior python Pull requests that update Python or Python-related code tests related to tests and/or testing infrastructure Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants