This repository was archived by the owner on Nov 24, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 353
Added Api contract test case for roles endpoint #7443
Merged
shamrickus
merged 8 commits into
apache:master
from
gokulakrishnansvm:api-contract-roles
Apr 14, 2023
Merged
Added Api contract test case for roles endpoint #7443
shamrickus
merged 8 commits into
apache:master
from
gokulakrishnansvm:api-contract-roles
Apr 14, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholguin
suggested changes
Apr 13, 2023
Contributor
ericholguin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes, everything else looks good. Tests are passing.
ericholguin
approved these changes
Apr 13, 2023
Contributor
ericholguin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TerekhovaKate
approved these changes
Apr 13, 2023
Member
|
Merge conflicts |
Member
|
@gokulakrishnansvm can you give this PR a better name. Something like "Added Api contract test case for roles endpoint" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
low impact
affects only a small portion of a CDN, and cannot itself break one
new feature
A new feature, capability or behavior
python
Pull requests that update Python or Python-related code
tests
related to tests and/or testing infrastructure
Traffic Ops
related to Traffic Ops
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Api contract test case for roles endpoint
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Step 1 : Install requirements
pip install -r requirements.txt
Step 2 : To execute roles API Contract Testcase , navigate to traffic_ops/testing/api_contract/v4
pytest --to-user Username --to-password Password --to-url URL --config Config Path --request-template Request template --response-template Response template test_roles.py
Note: Config, Request template and response template paths are optional.
PR submission checklist