Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@Kashatlast2
Copy link
Contributor

Adding API Contract Test Case for regions endpoint.


Which Traffic Control components are affected by this PR?

  • Traffic Ops Test

What is the best way to verify this PR?

Step 1 : Install requirements
pip install -r requirements.txt

Step 2 : To execute divisions API Contract Testcase , navigate to traffic_ops/testing/api_contract/v4
pytest --to-user Username --to-password Password --to-url URL --config Config Path --request-template Request template --response-template Response template test_regions.py

Note: Config, Request template and response template paths are optional.

PR submission checklist

@ocket8888 ocket8888 added Traffic Ops related to Traffic Ops low impact affects only a small portion of a CDN, and cannot itself break one tests related to tests and/or testing infrastructure improvement The functionality exists but it could be improved in some way. python Pull requests that update Python or Python-related code labels Apr 24, 2023
Copy link
Contributor

@ericholguin ericholguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some comments, also tests are failing

@Kashatlast2 Kashatlast2 requested a review from ericholguin May 10, 2023 20:08
Copy link
Contributor

@ericholguin ericholguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tests pass

@ericholguin ericholguin merged commit 40eee52 into apache:master May 10, 2023
@mitchell852
Copy link
Member

@gokulakrishnansvm - can you make the PR title more descriptive. maybe something like "Added Api contract tests for regions"

@mitchell852 mitchell852 changed the title Api contract regions Added regions api contract tests May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one python Pull requests that update Python or Python-related code tests related to tests and/or testing infrastructure Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants