This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Adding unit tests for cdn folder #7460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrhoffman
suggested changes
Apr 24, 2023
Member
zrhoffman
left a comment
zrhoffman
left a comment
There was a problem hiding this comment.
Just a small nit about license/import order
ocket8888
added
Traffic Ops
rimashah25
suggested changes
Apr 24, 2023
Contributor
rimashah25
left a comment
rimashah25
left a comment
There was a problem hiding this comment.
As soon as the license comments are addressed, the PR would LGTM. Tested all new unit tests locally and all seems to be working in order.
Codecov Report
@@ Coverage Diff @@
## master #7460 +/- ##
=============================================
- Coverage 61.13% 29.28% -31.86%
Complexity 98 98
=============================================
Files 303 782 +479
Lines 11581 81860 +70279
Branches 784 784
=============================================
+ Hits 7080 23970 +16890
- Misses 4154 55825 +51671
- Partials 347 2065 +1718
Flags with carried forward coverage won't be shown. Click here to find out more. see 481 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
srijeet0406
force-pushed
the
cdn_folder_test_coverage
branch
from
72da1c5 to
8723c06
Compare
rimashah25
approved these changes
Apr 25, 2023
zrhoffman
approved these changes
Apr 25, 2023
Member
zrhoffman
left a comment
zrhoffman
left a comment
There was a problem hiding this comment.
Looks good! The failing tests are not related to this PR.
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not related to any issue. It increases the test coverage in the
cdnfolder.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure the tests pass.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist