-
Notifications
You must be signed in to change notification settings - Fork 353
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7462 +/- ##
=========================================
Coverage 65.43% 65.44%
Complexity 98 98
=========================================
Files 305 305
Lines 11616 11621 +5
Branches 788 790 +2
=========================================
+ Hits 7601 7605 +4
- Misses 3667 3669 +2
+ Partials 348 347 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rimashah25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code change looks good to me.
I tried to test the changes on local to ensure buttons and anchors are still doing what they are supposed to and I am unable to login since login button is not working. So, I can't test any other buttons.
...ntal/traffic-portal/src/app/login/reset-password-dialog/reset-password-dialog.component.html
Outdated
Show resolved
Hide resolved
664561c to
ce3946e
Compare
experimental/traffic-portal/src/app/core/servers/server-details/server-details.component.html
Outdated
Show resolved
Hide resolved
experimental/traffic-portal/src/app/core/servers/phys-loc/table/phys-loc-table.component.html
Outdated
Show resolved
Hide resolved
also, some links incorrectly used `button` tags instead of `a` tags; fixed those too
ce3946e to
f393269
Compare
rimashah25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested locally button/link changes for login/users/physicalLocations/server/cachegroup. Unable to test deliveryservice or anything related to it.
This adds some linting rules for templates in TPv2. Right now, it's spitting out a bunch of warnings, which might be disabled entirely in the future (each one has an accompanying rationale in the configuration file). It also makes the code compliant with the linting rules. The biggest change is just that all buttons now must have an explicit
typeattribute - even when using the implicit defaultsubmittype. That helps catch buttons that shouldn't besubmittype, but also buttons incorrectly used as links etc.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure the code passes the new linting rules (albeit with warnings)
PR submission checklist