Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@ocket8888
Copy link
Contributor

This makes a few minor changes to the Cache Groups table.

  1. Cache Group-to-Parameter relationships are removed in APIv4.0 which TPv2 now uses, so the "Manage Parameters" context menu item has been removed.
  2. "Manage" isn't the right word for servers and ASNs, as the view to which it takes the user does not allow manipulations of those relationships, so they've been changed to "View"
  3. Implemented the "View Servers" context menu item.

Which Traffic Control components are affected by this PR?

  • Traffic Portal (experimental v2)

What is the best way to verify this PR?

Make sure the provided tests pass. Run TPv2 and use the "View Servers" action on a Cache Group.

PR submission checklist

  • This PR has tests
  • This PR doesn't need documentation
  • This PR doesn't need a CHANGELOG.md entry
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution experimental a feature/component not directly supported by ATC Traffic Portal v2 Related to the experimental Traffic Portal version 2 labels May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #7487 (f5ed33a) into master (8a0e416) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #7487      +/-   ##
============================================
- Coverage     65.51%   65.51%   -0.01%     
  Complexity       98       98              
============================================
  Files           309      309              
  Lines         11822    11821       -1     
  Branches        815      815              
============================================
- Hits           7745     7744       -1     
  Misses         3727     3727              
  Partials        350      350              
Flag Coverage Δ
traffic_portal_v2 76.10% <100.00%> (-0.01%) ⬇️
unit_tests 76.10% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/cache-group-table/cache-group-table.component.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ocket8888
Copy link
Contributor Author

Merging #7487 into master (e6af58a) will decrease coverage by 0.01%.

I don't understand how that's possible? The only file I changed has 100% coverage both before and after these changes

@ocket8888 ocket8888 force-pushed the tpv2/cg-table-updates branch from f8b4b5f to f5ed33a Compare May 22, 2023 20:17
Copy link
Member

@shamrickus shamrickus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shamrickus shamrickus merged commit 1cad456 into apache:master May 22, 2023
@ocket8888 ocket8888 deleted the tpv2/cg-table-updates branch May 23, 2023 17:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

experimental a feature/component not directly supported by ATC low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution Traffic Portal v2 Related to the experimental Traffic Portal version 2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants