This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix incorrect API version used when fetching server DSes #7499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocket8888
added
Traffic Portal v1
rimashah25
approved these changes
May 9, 2023
Contributor
rimashah25
left a comment
rimashah25
left a comment
There was a problem hiding this comment.
LGTM. Tested it local and an ACTIVE DS does appear as ACTIVE when assigned to a server instead of INACTIVE.
TP Tests failure are not related to this PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing display issues because the table was inheriting from the normal DS table, which assumes APIv5 DS object structure.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Go to a server with an assigned, active DS, and make sure that in the deliveryservices table for that server said DS is displayed as ACTIVE and not INACTIVE.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist