Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

TPv2 Upgrade Angular to 16 #7562

Merged
ocket8888 merged 5 commits into from
Jun 15, 2023
Merged

TPv2 Upgrade Angular to 16 #7562

ocket8888 merged 5 commits into from
Jun 15, 2023

Conversation

@shamrickus
Copy link
Member

@shamrickus shamrickus commented Jun 7, 2023

This PR updates Angular to version 16 from 15.

Which Traffic Control components are affected by this PR?

  • Traffic Portal v2

What is the best way to verify this PR?

Ensure build/lint/tests pass. Make sure TPv2 works and looks the same as before. Also consult the upgrading guide to ensure nothing was missed see this

PR submission checklist

@shamrickus shamrickus added low impact affects only a small portion of a CDN, and cannot itself break one experimental a feature/component not directly supported by ATC dependencies Pull requests that update a dependency file Traffic Portal v2 Related to the experimental Traffic Portal version 2 labels Jun 7, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 7, 2023
View reviewed changes
...c-portal/src/app/core/deliveryservice/new-delivery-service/new-delivery-service.component.ts
* A regular expression that matches a valid hostname
*/
const VALID_HOSTNAME = /^[A-z\d]([A-z0-9\-]*[A-z0-9])?(\.[A-z\d]([A-z0-9\-]*[A-z0-9])?)*$/;
const VALID_HOSTNAME = /^[A-z\d]([A-z0-9-]*[A-z0-9])?(\.[A-z\d]([A-z0-9-]*[A-z0-9])?)*$/;

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that is equivalent to \[A-Z\\[\\\\]^_`a-z\].
...c-portal/src/app/core/deliveryservice/new-delivery-service/new-delivery-service.component.ts
* A regular expression that matches a valid hostname
*/
const VALID_HOSTNAME = /^[A-z\d]([A-z0-9\-]*[A-z0-9])?(\.[A-z\d]([A-z0-9\-]*[A-z0-9])?)*$/;
const VALID_HOSTNAME = /^[A-z\d]([A-z0-9-]*[A-z0-9])?(\.[A-z\d]([A-z0-9-]*[A-z0-9])?)*$/;

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that is equivalent to \[A-Z\\[\\\\]^_`a-z\].
...c-portal/src/app/core/deliveryservice/new-delivery-service/new-delivery-service.component.ts
* A regular expression that matches a valid hostname
*/
const VALID_HOSTNAME = /^[A-z\d]([A-z0-9\-]*[A-z0-9])?(\.[A-z\d]([A-z0-9\-]*[A-z0-9])?)*$/;
const VALID_HOSTNAME = /^[A-z\d]([A-z0-9-]*[A-z0-9])?(\.[A-z\d]([A-z0-9-]*[A-z0-9])?)*$/;

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that is equivalent to \[A-Z\\[\\\\]^_`a-z\].
...c-portal/src/app/core/deliveryservice/new-delivery-service/new-delivery-service.component.ts
* A regular expression that matches a valid hostname
*/
const VALID_HOSTNAME = /^[A-z\d]([A-z0-9\-]*[A-z0-9])?(\.[A-z\d]([A-z0-9\-]*[A-z0-9])?)*$/;
const VALID_HOSTNAME = /^[A-z\d]([A-z0-9-]*[A-z0-9])?(\.[A-z\d]([A-z0-9-]*[A-z0-9])?)*$/;

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that is equivalent to \[A-Z\\[\\\\]^_`a-z\].
...c-portal/src/app/core/deliveryservice/new-delivery-service/new-delivery-service.component.ts
* A regular expression that matches a valid hostname
*/
const VALID_HOSTNAME = /^[A-z\d]([A-z0-9\-]*[A-z0-9])?(\.[A-z\d]([A-z0-9\-]*[A-z0-9])?)*$/;
const VALID_HOSTNAME = /^[A-z\d]([A-z0-9-]*[A-z0-9])?(\.[A-z\d]([A-z0-9-]*[A-z0-9])?)*$/;

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that is equivalent to \[A-Z\\[\\\\]^_`a-z\].
...c-portal/src/app/core/deliveryservice/new-delivery-service/new-delivery-service.component.ts
* A regular expression that matches a valid hostname
*/
const VALID_HOSTNAME = /^[A-z\d]([A-z0-9\-]*[A-z0-9])?(\.[A-z\d]([A-z0-9\-]*[A-z0-9])?)*$/;
const VALID_HOSTNAME = /^[A-z\d]([A-z0-9-]*[A-z0-9])?(\.[A-z\d]([A-z0-9-]*[A-z0-9])?)*$/;

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that is equivalent to \[A-Z\\[\\\\]^_`a-z\].
@codecov
Copy link

codecov bot commented Jun 7, 2023 •
edited
Loading

Codecov Report

Merging #7562 (322bd5c) into master (2e995e7) will increase coverage by 37.64%.
The diff coverage is 50.00%.

❗ Current head 322bd5c differs from pull request most recent head 3d48977. Consider uploading reports for the commit 3d48977 to get more accurate results

@@              Coverage Diff              @@
##             master    #7562       +/-   ##
=============================================
+ Coverage     27.74%   65.39%   +37.64%     
  Complexity       98       98               
=============================================
  Files           686      312      -374     
  Lines         78128    12199    -65929     
  Branches         90      885      +795     
=============================================
- Hits          21675     7977    -13698     
+ Misses        54396     3873    -50523     
+ Partials       2057      349     -1708
Flag Coverage Δ
golib_unit ?
grove_unit ?
t3c_unit ?
traffic_monitor_unit ?
traffic_ops_unit ?
traffic_portal_v2 74.95% <50.00%> (?)
traffic_stats_unit ?
unit_tests 74.95% <50.00%> (+50.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cache-config/t3c-generate/cfgfile/wrappers.go 49.57% <ø> (+0.12%) ⬆️
cache-config/t3c-generate/config/config.go 0.89% <ø> (ø)
...al/src/app/api/testing/delivery-service.service.ts 63.00% <ø> (ø)
...affic-portal/src/app/api/testing/server.service.ts 41.25% <0.00%> (ø)
.../core/deliveryservice/ds-card/ds-card.component.ts 82.25% <ø> (ø)
.../profiles/profile-table/profile-table.component.ts 82.50% <ø> (ø)
...ore/servers/capabilities/capabilities.component.ts 100.00% <ø> (ø)
...servers/server-details/server-details.component.ts 62.32% <ø> (ø)
...tatuses/status-details/status-details.component.ts 57.14% <0.00%> (ø)
...l/src/app/shared/interceptor/alerts.interceptor.ts 12.50% <0.00%> (ø)
... and 5 more

... and 573 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ocket8888
ocket8888 reviewed Jun 9, 2023
View reviewed changes
@shamrickus
Copy link
Member Author

shamrickus commented Jun 13, 2023

Not sure why the E2E tests are failing, should be using chromedriver 114 and they pass locally.

ocket8888
ocket8888 approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests are flaky due to latest Chrome not being in the Ubuntu repos yet - without any way of knowing when that'll be fixed, I'm just going to have to merge this without the tests passing in GHA.

@ocket8888 ocket8888 merged commit c1bcb90 into apache:master Jun 15, 2023
jagan-parthiban pushed a commit to jagan-parthiban/trafficcontrol that referenced this pull request Jun 24, 2023
@shamrickus @jagan-parthiban
TPv2 Upgrade Angular to 16 (apache#7562)
35c12df 
* Upgrade Angular to 16

* Fix build

* Fix server build

* Revert eslint:recommended changes, add missing rules from compat

* Regenerate package-lock
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ocket8888 ocket8888 ocket8888 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file experimental a feature/component not directly supported by ATC low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v2 Related to the experimental Traffic Portal version 2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shamrickus @ocket8888