Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@asf-ci-trafficcontrol
Copy link
Contributor

This PR updates chromedriver in:
traffic_portal/test/integration: 112.0.1 -> 114.0.1
experimental/traffic-portal: 112.0.1 -> 114.0.1

Which Traffic Control components are affected by this PR?

  • Traffic Portal
  • Traffic Portal v2

What is the best way to verify this PR?

Verify that the affected e2e tests pass.

PR submission checklist

@asf-ci-trafficcontrol asf-ci-trafficcontrol added dependencies Pull requests that update a dependency file tests related to tests and/or testing infrastructure Traffic Portal v1 related to Traffic Portal version 1 Traffic Portal v2 Related to the experimental Traffic Portal version 2 labels Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #7566 (ada98d3) into master (2e995e7) will increase coverage by 2.70%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7566      +/-   ##
============================================
+ Coverage     27.74%   30.44%   +2.70%     
  Complexity       98       98              
============================================
  Files           686      792     +106     
  Lines         78128    82868    +4740     
  Branches         90      885     +795     
============================================
+ Hits          21675    25229    +3554     
- Misses        54396    55526    +1130     
- Partials       2057     2113      +56     
Flag Coverage Δ
golib_unit 48.56% <ø> (+<0.01%) ⬆️
grove_unit 4.60% <ø> (ø)
t3c_unit 5.32% <ø> (ø)
traffic_monitor_unit 21.35% <ø> (ø)
traffic_ops_integration 69.42% <ø> (ø)
traffic_ops_unit 23.42% <ø> (ø)
traffic_portal_v2 74.95% <ø> (?)
traffic_router_unit 29.03% <ø> (ø)
traffic_stats_unit 10.14% <ø> (ø)
unit_tests 27.55% <ø> (+3.14%) ⬆️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 107 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@shamrickus shamrickus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TP test failures are unrelated to this update, appears to be related to GHA only.

@shamrickus shamrickus merged commit 5690ce3 into master Jun 8, 2023
@shamrickus shamrickus deleted the ATC-Chromedriver-Updater branch June 8, 2023 13:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file tests related to tests and/or testing infrastructure Traffic Portal v1 related to Traffic Portal version 1 Traffic Portal v2 Related to the experimental Traffic Portal version 2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants