Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@ezelkow1
Copy link
Member

@ezelkow1 ezelkow1 commented Jun 15, 2023

This reworks the maxmind -M option to take a comma separated list if a user wishes to download multiple databases


Which Traffic Control components are affected by this PR?

  • Traffic Control Cache Config (t3c, formerly ORT)

What is the best way to verify this PR?

Do a t3c run with the -M option and a single URL to check the original use works. Then can re-run with multiple comma separated URLs and check that they all download/update

PR submission checklist

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #7580 (44c6d3d) into master (2e995e7) will decrease coverage by 2.19%.
The diff coverage is 20.84%.

❗ Current head 44c6d3d differs from pull request most recent head a7853ef. Consider uploading reports for the commit a7853ef to get more accurate results

@@             Coverage Diff              @@
##             master    #7580      +/-   ##
============================================
- Coverage     27.74%   25.55%   -2.19%     
  Complexity       98       98              
============================================
  Files           686      574     -112     
  Lines         78128    74266    -3862     
  Branches         90       90              
============================================
- Hits          21675    18982    -2693     
+ Misses        54396    53390    -1006     
+ Partials       2057     1894     -163     
Flag Coverage Δ
golib_unit 48.58% <66.07%> (+0.02%) ⬆️
grove_unit 4.60% <ø> (ø)
t3c_unit 5.31% <2.08%> (-0.01%) ⬇️
traffic_monitor_unit 21.35% <ø> (ø)
traffic_ops_unit 23.31% <7.54%> (-0.12%) ⬇️
traffic_stats_unit 10.14% <ø> (ø)
unit_tests 24.35% <17.08%> (-0.06%) ⬇️
v3 ?
v4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cache-config/t3c-apply/config/config.go 0.00% <0.00%> (ø)
cache-config/t3c-apply/t3c-apply.go 0.00% <0.00%> (ø)
cache-config/t3c-apply/torequest/cmd.go 0.00% <0.00%> (ø)
cache-config/t3c-apply/util/util.go 4.82% <0.00%> (ø)
cache-config/t3c-generate/config/config.go 0.83% <0.00%> (-0.06%) ⬇️
...c_ops/traffic_ops_golang/coordinate/coordinates.go 21.32% <3.51%> (-44.03%) ⬇️
cache-config/t3c-generate/cfgfile/wrappers.go 49.45% <50.00%> (+<0.01%) ⬆️
traffic_ops/traffic_ops_golang/api/api.go 30.79% <55.55%> (+0.27%) ⬆️
lib/go-atscfg/parentdotconfig.go 65.76% <64.15%> (-0.48%) ⬇️
lib/go-atscfg/parentabstraction.go 79.47% <100.00%> (-0.53%) ⬇️
... and 4 more

... and 113 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ocket8888 ocket8888 added new feature A new feature, capability or behavior low impact affects only a small portion of a CDN, and cannot itself break one cache-config Cache config generation labels Jun 15, 2023
@ocket8888
Copy link
Contributor

the new option should be added to the documentation

@ezelkow1
Copy link
Member Author

the new option should be added to the documentation

thanks, added to the t3c-apply docs

@ezelkow1
Copy link
Member Author

Actually I may rework this to take a comma separated list of URLs instead of tacking on another option since some people just want to be able to grab multiple db's at once

… list of URLs of databases. So now it works through each URL in turn doing the 304 check and unpack
@ezelkow1 ezelkow1 changed the title Add maxmind anonymous download option to t3c Change t3c -M option to take a comma separated list Jun 21, 2023
@ezelkow1 ezelkow1 requested a review from traeak June 23, 2023 20:13
@shamrickus shamrickus merged commit a1c3a2e into apache:master Jun 28, 2023
@ezelkow1 ezelkow1 deleted the t3c-anon branch June 28, 2023 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cache-config Cache config generation low impact affects only a small portion of a CDN, and cannot itself break one new feature A new feature, capability or behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants