Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@rimashah25
Copy link
Contributor

Reverts back all the TM changes to fix bandwidth bug


Which Traffic Control components are affected by this PR?

  • Traffic Monitor

What is the best way to verify this PR?

If this is a bugfix, which Traffic Control versions contained the bug?

7.0.1

PR submission checklist

@rimashah25 rimashah25 marked this pull request as ready for review June 29, 2023 22:47
@zrhoffman zrhoffman added Traffic Monitor related to Traffic Monitor regression bug a bug in existing functionality introduced by a new version labels Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #7606 (3ae5fda) into master (4cc489c) will decrease coverage by 36.84%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             master    #7606       +/-   ##
=============================================
- Coverage     65.22%   28.39%   -36.84%     
  Complexity       98       98               
=============================================
  Files           313      681      +368     
  Lines         12292    79562    +67270     
  Branches        896      896               
=============================================
+ Hits           8018    22593    +14575     
- Misses         3923    55014    +51091     
- Partials        351     1955     +1604     
Flag Coverage Δ
golib_unit 48.59% <ø> (?)
grove_unit 4.60% <ø> (?)
t3c_unit 5.29% <ø> (?)
traffic_monitor_unit 21.28% <100.00%> (?)
traffic_ops_integration 79.18% <ø> (+9.76%) ⬆️
traffic_ops_unit 23.06% <ø> (?)
traffic_portal_v2 74.35% <ø> (ø)
traffic_stats_unit 10.14% <ø> (?)
unit_tests 27.34% <100.00%> (-47.02%) ⬇️
v3 ?
v4 79.18% <ø> (ø)
v5 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
traffic_monitor/cache/cache.go 45.51% <ø> (ø)
traffic_monitor/health/cache.go 59.28% <100.00%> (ø)

... and 592 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zrhoffman zrhoffman merged commit 39aea9f into master Jun 29, 2023
@zrhoffman zrhoffman deleted the revert-TM-changes-for-bandwidth-bug branch June 29, 2023 22:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

regression bug a bug in existing functionality introduced by a new version Traffic Monitor related to Traffic Monitor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants