This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fixing DELETE delivery service request comments getting null xml_id #7664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not related to an issue. It fixes the select query in delivery service request comments so that it retrieves the correct xml_id for the delivery service in case of DELETE DSRs.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure the tests pass.
Manual testing:
Create a DELETE DSR in traffic ops/ traffic portal
Try to select this particular DSR from TP, or GET it through the API call in TO
Make sure you get the expected DSR back in the response
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist