Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@srijeet0406
Copy link
Contributor

This PR is not related to an issue. It fixes the select query in delivery service request comments so that it retrieves the correct xml_id for the delivery service in case of DELETE DSRs.


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Make sure the tests pass.
Manual testing:
Create a DELETE DSR in traffic ops/ traffic portal
Try to select this particular DSR from TP, or GET it through the API call in TO
Make sure you get the expected DSR back in the response

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

@srijeet0406 srijeet0406 added bug something isn't working as intended Traffic Ops related to Traffic Ops labels Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #7664 (0aa7d45) into master (75ec56f) will decrease coverage by 34.99%.
The diff coverage is 11.63%.

@@              Coverage Diff              @@
##             master    #7664       +/-   ##
=============================================
- Coverage     65.05%   30.07%   -34.99%     
  Complexity       98       98               
=============================================
  Files           314      794      +480     
  Lines         12365    84265    +71900     
  Branches        907      905        -2     
=============================================
+ Hits           8044    25339    +17295     
- Misses         3968    56793    +52825     
- Partials        353     2133     +1780     
Flag Coverage Δ
golib_unit 48.26% <0.00%> (?)
grove_unit 4.60% <ø> (?)
t3c_unit 5.28% <ø> (?)
traffic_monitor_unit 21.30% <0.00%> (?)
traffic_ops_integration 69.39% <78.57%> (-0.03%) ⬇️
traffic_ops_unit 22.86% <5.76%> (?)
traffic_portal_v2 73.92% <87.50%> (+0.14%) ⬆️
traffic_stats_unit 10.14% <ø> (?)
unit_tests 27.19% <8.04%> (-46.59%) ⬇️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.52% <78.57%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/go-tc/federation_resolver.go 45.45% <0.00%> (ø)
traffic_monitor/tmclient/tmclient.go 0.00% <0.00%> (ø)
...fic_ops/traffic_ops_golang/deliveryservice/keys.go 31.86% <0.00%> (ø)
...affic_ops/traffic_ops_golang/division/divisions.go 8.45% <0.00%> (ø)
...olang/federation_resolvers/federation_resolvers.go 0.00% <0.00%> (ø)
traffic_ops/traffic_ops_golang/login/login.go 10.86% <0.00%> (ø)
traffic_ops/traffic_ops_golang/auth/certificate.go 42.98% <50.00%> (ø)
...fic_ops/traffic_ops_golang/dbhelpers/db_helpers.go 21.17% <50.00%> (ø)
traffic_ops/v5-client/session.go 72.22% <50.00%> (-2.78%) ⬇️
...ffic-portal/src/app/api/testing/profile.service.ts 47.88% <66.66%> (+3.73%) ⬆️
... and 7 more

... and 473 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@srijeet0406 srijeet0406 requested a review from ericholguin July 20, 2023 17:45
Copy link
Contributor

@ericholguin ericholguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to view a delivery service delete request with no ISE

@ericholguin ericholguin merged commit ff64922 into apache:master Jul 20, 2023
jagan-parthiban pushed a commit to jagan-parthiban/trafficcontrol that referenced this pull request Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants