Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@rimashah25
Copy link
Contributor

Using go-rfc package for location header instead of a string value.


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Ensure all features work correctly.

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

@rimashah25 rimashah25 added Traffic Ops related to Traffic Ops tech debt rework due to choosing easy/limited solution labels Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #7748 (1212b75) into master (aabc8cf) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #7748      +/-   ##
============================================
- Coverage     32.14%   32.13%   -0.01%     
  Complexity       98       98              
============================================
  Files           712      712              
  Lines         81252    81252              
  Branches        965      965              
============================================
- Hits          26115    26113       -2     
- Misses        52992    52994       +2     
  Partials       2145     2145              
Flag Coverage Δ
golib_unit 53.70% <ø> (ø)
grove_unit 12.02% <ø> (ø)
t3c_unit 5.99% <ø> (ø)
traffic_monitor_unit 26.33% <ø> (ø)
traffic_ops_integration 69.38% <ø> (ø)
traffic_ops_unit 21.93% <0.00%> (ø)
traffic_portal_v2 74.36% <ø> (-0.04%) ⬇️
traffic_stats_unit 10.76% <ø> (ø)
unit_tests 29.44% <0.00%> (-0.01%) ⬇️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
traffic_ops/traffic_ops_golang/asn/asns.go 14.60% <0.00%> (ø)
...c_ops/traffic_ops_golang/cachegroup/cachegroups.go 14.93% <0.00%> (ø)
traffic_ops/traffic_ops_golang/cdn/cdns.go 28.15% <0.00%> (ø)
...fic_ops_golang/deliveryservice/deliveryservices.go 17.67% <0.00%> (ø)
...fic_ops_golang/deliveryservice/request/requests.go 2.37% <0.00%> (ø)
...affic_ops/traffic_ops_golang/division/divisions.go 8.45% <0.00%> (ø)
...ic_ops_golang/invalidationjobs/invalidationjobs.go 0.00% <0.00%> (ø)
.../traffic_ops_golang/physlocation/phys_locations.go 10.02% <0.00%> (ø)
...ic_ops_golang/servercapability/servercapability.go 10.12% <0.00%> (ø)
...ic_ops_golang/servicecategory/servicecategories.go 10.21% <0.00%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ocket8888 ocket8888 merged commit 5c71ca6 into apache:master Aug 26, 2023
@rimashah25 rimashah25 deleted the refactor/version branch August 28, 2023 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants