Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@rimashah25
Copy link
Contributor

@rimashah25 rimashah25 commented Sep 7, 2023

Not related to any issue but a clean up of seeds.sql file


Which Traffic Control components are affected by this PR?

  • Traffic Ops DB

What is the best way to verify this PR?

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

@rimashah25 rimashah25 changed the title cleaned seeds.sql file Removed duplicate statements from seeds file Sep 7, 2023
@rimashah25 rimashah25 marked this pull request as ready for review September 7, 2023 21:17
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #7790 (1d66988) into master (75ec56f) will increase coverage by 0.57%.
Report is 118 commits behind head on master.
The diff coverage is 74.17%.

@@             Coverage Diff              @@
##             master    #7790      +/-   ##
============================================
+ Coverage     65.05%   65.62%   +0.57%     
  Complexity       98       98              
============================================
  Files           314      323       +9     
  Lines         12365    12833     +468     
  Branches        907      965      +58     
============================================
+ Hits           8044     8422     +378     
- Misses         3968     4051      +83     
- Partials        353      360       +7     
Flag Coverage Δ
traffic_portal_v2 74.39% <74.17%> (+0.61%) ⬆️
unit_tests 74.39% <74.17%> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cache-config/t3c-generate/config/config.go 0.89% <ø> (ø)
cache-config/t3c-generate/t3c-generate.go 0.00% <ø> (ø)
experimental/traffic-portal/src/app/api/index.ts 100.00% <ø> (ø)
...mental/traffic-portal/src/app/api/testing/index.ts 100.00% <ø> (ø)
...perimental/traffic-portal/src/app/app.ui.module.ts 100.00% <ø> (ø)
...tatuses/statuses-table/statuses-table.component.ts 82.35% <ø> (ø)
...al/src/app/shared/interceptor/error.interceptor.ts 3.12% <0.00%> (-0.21%) ⬇️
...tal/traffic-portal/src/app/shared/shared.module.ts 100.00% <ø> (ø)
experimental/traffic-portal/src/app/utils/index.ts 100.00% <ø> (ø)
...tal/traffic-portal/src/environments/environment.ts 100.00% <ø> (ø)
... and 60 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

@ocket8888 ocket8888 self-assigned this Sep 7, 2023
@ocket8888 ocket8888 added Traffic Ops related to Traffic Ops low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution database relating to setup/installation/structure of the Traffic Ops database labels Sep 7, 2023
@rimashah25 rimashah25 requested a review from ocket8888 September 7, 2023 22:01
@ocket8888 ocket8888 merged commit 3a43e40 into apache:master Sep 7, 2023
@rimashah25 rimashah25 deleted the agg-roles-seeds branch September 7, 2023 23:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

database relating to setup/installation/structure of the Traffic Ops database low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants