This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Update CDN in a Box enroller to use TO API v5 #7795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrhoffman
added
tech debt
Codecov Report
@@ Coverage Diff @@
## master #7795 +/- ##
=============================================
- Coverage 65.61% 28.85% -36.77%
Complexity 98 98
=============================================
Files 323 599 +276
Lines 12833 77053 +64220
Branches 965 90 -875
=============================================
+ Hits 8421 22230 +13809
- Misses 4051 52738 +48687
- Partials 361 2085 +1724
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 512 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zrhoffman
force-pushed
the
ciab-enroller-v5
branch
from
f801c5d to
c051527
Compare
jpappa200
approved these changes
Sep 11, 2023
Contributor
jpappa200
left a comment
jpappa200
left a comment
There was a problem hiding this comment.
Looks good to me, just waiting on CI
zrhoffman
force-pushed
the
ciab-enroller-v5
branch
from
caa819a to
31aa9a2
Compare
ocket8888
reviewed
Sep 12, 2023
zrhoffman
force-pushed
the
ciab-enroller-v5
branch
from
31aa9a2 to
565c526
Compare
Member
Author
|
Rebased |
ocket8888
approved these changes
Sep 12, 2023
Contributor
|
I can't tell why this would fail the tests just by looking at it, but they seem to be failing consistently |
zrhoffman
force-pushed
the
ciab-enroller-v5
branch
from
1706f80 to
b7fd246
Compare
ocket8888
approved these changes
Sep 13, 2023
ocket8888
added
the
medium impact
rimashah25
pushed a commit
to rimashah25/trafficcontrol
that referenced
this pull request
Sep 18, 2023
* Session.CreateServerCapabilityV5 -> Session.CreateServerCapability * Session.GetServerCapabilitiesV5 -> Session.GetServerCapabilities * Session.UpdateServerCapabilityV5 -> Session.UpdateServerCapability * Update CiaB enroller to use TO API v5 * Update field names for API v5 * Remove server response ID validation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the CDN in a Box enroller use Traffic Ops API version 5.
This PR also removes
V5from some API v5 TO client method names.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Verify that GitHub Actions pass
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist