Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@ocket8888
Copy link
Contributor

This PR addresses some issues with our API documentation. Its primary purpose, though, is to add in all of the .. versionchanged:: directives that are missing from fields that were changed in APIv5, namely: the fields that used to be non-RFC datetimes and are now in RFC3339 format.

Other problems include:

  • incorrectly documented endpoints (wrong timestamp format in descriptions and/or examples, missing fields, etc.)
  • grammatical errors
  • formatting errors (tabs used for alignment, spaces used for indentation, trailing whitespace, missing terminating newlines etc.)

Which Traffic Control components are affected by this PR?

  • Documentation

What is the best way to verify this PR?

Make sure the docs build without any errors or warnings

If this is a bugfix, which Traffic Control versions contained the bug?

  • master
  • for some parts, 7.x

PR submission checklist

  • This PR doesn't need tests
  • This PR is only documentation changes
  • This PR doesn't need a CHANGELOG.md entry
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added bug something isn't working as intended documentation related to documentation low impact affects only a small portion of a CDN, and cannot itself break one labels Sep 12, 2023
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this once the conflicts are fixed

tabs used for alignment, spaces used as indentation, etc.
Mostly this means the spacing and alignment in field lists, but also
some of the fields got out of lexical order as well, and I ensured
terminating newlines where they were missing
Mostly this relates to places where timestamps are incorrectly labeled
as either RFC or non-RFC, but also includes an unnecessary versionadded
directive, incorrect response types,
@zrhoffman zrhoffman merged commit e245f95 into apache:master Sep 28, 2023
@ocket8888 ocket8888 deleted the docs/cleanup branch September 29, 2023 02:42
rimashah25 pushed a commit that referenced this pull request Jan 19, 2024
* Fix indentation and alignment errors

tabs used for alignment, spaces used as indentation, etc.

* trim trailing whitespace

* Add missing admonitions for timestamp format changes

* Fix formatting

Mostly this means the spacing and alignment in field lists, but also
some of the fields got out of lexical order as well, and I ensured
terminating newlines where they were missing

* Fix inaccurate/incorrect documentation

Mostly this relates to places where timestamps are incorrectly labeled
as either RFC or non-RFC, but also includes an unnecessary versionadded
directive, incorrect response types,

* Grammar fixes, add term links, add response field description

* Fix bad automatic merge changes

(cherry picked from commit e245f95)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended documentation related to documentation low impact affects only a small portion of a CDN, and cannot itself break one

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants