Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@shamrickus
Copy link
Member

This PR fixes an issue with the sidebar styling not covering the entire height of the screen and it fixes an issue with the theme-manager.service.ts throwing errors when run in server mode. It also adds functionality for the theme-manager to detect the browsers Prefer Color Scheme setting and will set it to the dark theme if that is preference.


Which Traffic Control components are affected by this PR?

  • Traffic Portal v2

What is the best way to verify this PR?

Open up sidebar entries until it overflows the height, verify that you the actions bar at the bottom covers the sidebar completely
issue
Set your browsers Prefer Color Scheme to dark in the browser settings, clear all local browser data from TPv2, and load the page. It should switch to the dark mode by default.

PR submission checklist

@shamrickus shamrickus added bug something isn't working as intended new feature A new feature, capability or behavior Traffic Portal v2 Related to the experimental Traffic Portal version 2 labels Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #7813 (a7e3231) into master (a6b2954) will decrease coverage by 0.01%.
Report is 5 commits behind head on master.
The diff coverage is 81.48%.

@@             Coverage Diff              @@
##             master    #7813      +/-   ##
============================================
- Coverage     65.64%   65.63%   -0.01%     
  Complexity       98       98              
============================================
  Files           323      323              
  Lines         12827    12838      +11     
  Branches        965      970       +5     
============================================
+ Hits           8420     8426       +6     
- Misses         4048     4052       +4     
- Partials        359      360       +1     
Flag Coverage Δ
traffic_portal_v2 74.35% <81.48%> (-0.05%) ⬇️
unit_tests 74.35% <81.48%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../app/shared/theme-manager/theme-manager.service.ts 86.66% <81.48%> (-5.18%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zrhoffman zrhoffman merged commit 314f906 into apache:master Sep 22, 2023
@shamrickus shamrickus deleted the tpv2/misc branch September 22, 2023 19:37
jpappa200 pushed a commit to jpappa200/trafficcontrol that referenced this pull request Sep 27, 2023
* Fix sidebar not covering bottom

* Fix theme-manager and detect color scheme

* Add wrapping

* Fix tests

---------

Co-authored-by: Steve Hamrick <shamrick@apache.org>
rimashah25 pushed a commit that referenced this pull request Oct 23, 2023
* Fix sidebar not covering bottom

* Fix theme-manager and detect color scheme

* Add wrapping

* Fix tests

---------

Co-authored-by: Steve Hamrick <shamrick@apache.org>
(cherry picked from commit 314f906)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended new feature A new feature, capability or behavior Traffic Portal v2 Related to the experimental Traffic Portal version 2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants