Cleanup for optimised builds - #10578
Closed
cmcfarlen wants to merge 1 commit into
Closed
Conversation
JosiahWI
approved these changes
Oct 11, 2023
JosiahWI
left a comment
JosiahWI
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this looks great! The way the esi plugin is laid out is kind of messy and it would be good to improve it in a separate PR.
cmcfarlen
force-pushed
the
cmake-pic-and-cleanup
branch
from
October 12, 2023 01:27
c2de359 to
ca236ff
Compare
cmcfarlen
marked this pull request as draft
October 16, 2023 22:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LTO builds were having linking problems with clang 16 due to lack of PIC. This marks static libs PIC and cleans up some link library calls.