TS-4970: Crash in INKVConnInternal when handle_event is called after destroy() - #1109
TS-4970: Crash in INKVConnInternal when handle_event is called after destroy()#1109jacksontj wants to merge 1 commit into
Conversation
d999852 to
5f6693a
Compare
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1009/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/901/ for details. |
|
Are we using github for backports? I thought the process was to mark the JIRA? |
|
@jpeach TBH I'm not sure, I figured the PR would be good at least to get the CI to run on it-- I'm not sure what our official process is now that we do github for some things |
|
Does the |
|
Would it be easier to just back port the fix from TS-4590? I'm a bit concerned about the proposed fix in this PR. I don't think is correctly using the m_deleted/m_deletable parameters? |
|
@shinrich we could-- this patch seems to be working fine for our build though-- seemed like a less intrusive patch to an LTS release. |
|
@shinrich I did look a bit more into the other backport-- and it seems that the outcome would be quite similar-- as the |
5f6693a to
49b6fb6
Compare
|
After doing some more looking, the |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1035/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/927/ for details. |
|
Is this a duplicate PR? |
|
Not a complete solution as Thomas noted, but may be sufficient to keep 6.2.x moving. Alternatively, we may just want to back port TS-4590. |
|
Closing the PR-- as we'll take care of this in Jira. |
…pache#1109) proxy.config.ssl.session_cache.value allows the user to configure whether OpenSSL internally manages the TLS session cache for resumption or whether ATS does via callbacks. For our user_agent_session_* metrics, we use the SSL_CTX_sess_* OpenSSL API to populate them. This works for hit, timeout, etc, for both when the session cache is managed by OpenSSL and when it is managed by ATS, with the exception of SSL_CTX_sess_misses. That metric only counts internal cache misses: > SSL_CTX_sess_misses() returns the number of sessions proposed by > clients that were not found in the internal session cache in server > mode. The result is that when ATS manages the session cache, which is the default configuration, proxy.process.ssl.user_agent_session_miss is always zero. This patch uses our ssl_session_cache_miss metric to augment the stat to be accurate for ATS-managed caching. (cherry picked from commit 75f194c)
6 participants
No description provided.