Skip to content

Remove unneeded malloc from url_rewrite debug path for HOST header. - #1207

Merged
SolidWallOfCode merged 1 commit into
apache:masterfrom
SolidWallOfCode:amc-debug-cleanup-url-rewrite-host-header
Nov 8, 2016
Merged

Remove unneeded malloc from url_rewrite debug path for HOST header.#1207
SolidWallOfCode merged 1 commit into
apache:masterfrom
SolidWallOfCode:amc-debug-cleanup-url-rewrite-host-header

Conversation

@SolidWallOfCode

Copy link
Copy Markdown
Member

The comments claim to copy to get the terminating null, but that's not needed. I tested it and as expected it works fine without the allocation & copy.

@atsci

atsci commented Nov 7, 2016

Copy link
Copy Markdown

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1191/ for details.

@atsci

atsci commented Nov 7, 2016

Copy link
Copy Markdown

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1084/ for details.

@zwoop zwoop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zwoop zwoop added the Cleanup label Nov 7, 2016
@zwoop zwoop added this to the 7.1.0 milestone Nov 7, 2016
@zwoop zwoop self-assigned this Nov 7, 2016
@SolidWallOfCode
SolidWallOfCode merged commit 9d11d6f into apache:master Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants