Skip to content

TS-5061 TS use ats_malloc instead of malloc in log module - #1229

Merged
zwoop merged 2 commits into
apache:7.0.xfrom
scw00:7.0.x
Dec 4, 2016
Merged

TS-5061 TS use ats_malloc instead of malloc in log module#1229
zwoop merged 2 commits into
apache:7.0.xfrom
scw00:7.0.x

Conversation

@scw00

@scw00 scw00 commented Nov 21, 2016

Copy link
Copy Markdown
Member

It should be abort immediately while malloc failed . So why do not use ats_malloc instead of malloc?

@jpeach

jpeach commented Nov 21, 2016

Copy link
Copy Markdown
Contributor

[approve ci]

@atsci

atsci commented Nov 21, 2016

Copy link
Copy Markdown

Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/1101/ for details.

@atsci

atsci commented Nov 21, 2016

Copy link
Copy Markdown

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1208/ for details.

@zwoop zwoop added the Logging label Nov 23, 2016
@zwoop zwoop added this to the 7.1.0 milestone Nov 23, 2016
@zwoop zwoop self-assigned this Nov 23, 2016
@zwoop

zwoop commented Nov 23, 2016

Copy link
Copy Markdown
Contributor

This needs to be updated with clang-format. Easiest is to just run

$ make clang-format

and then push the branch again to update the PR.

@zwoop

zwoop commented Dec 2, 2016

Copy link
Copy Markdown
Contributor

[approve ci]

@atsci

atsci commented Dec 2, 2016

Copy link
Copy Markdown

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1238/ for details.

@atsci

atsci commented Dec 2, 2016

Copy link
Copy Markdown

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1133/ for details.

@zwoop
zwoop merged commit c8358cf into apache:7.0.x Dec 4, 2016
@zwoop

zwoop commented Dec 5, 2016

Copy link
Copy Markdown
Contributor

Well dammit, I screwed up, this PR was against the 7.0.x branch :-/ Can you please make a new PR against master please? I will undo the 7.0.x commit.

@scw00

scw00 commented Dec 6, 2016

Copy link
Copy Markdown
Member Author

Here is another one , Sorry!
#1249

shinrich pushed a commit to shinrich/trafficserver that referenced this pull request Jul 15, 2017
shinrich pushed a commit to shinrich/trafficserver that referenced this pull request Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants